[oadp-1.4] bundle createdAt sed for macOS#1405
Conversation
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
I'm just gonna avoid in-place and use mv |
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
rayfordj
left a comment
There was a problem hiding this comment.
/lgtm
$ make bundle
----8<----
INFO[0000] All validation tests have completed successfully
sed -e 's/ createdAt: .*/ createdAt: "2024-05-29T17:22:16Z"/' bundle/manifests/oadp-operator.clusterserviceversion.yaml > bundle/manifests/oadp-operator.clusterserviceversion.yaml.tmp
mv bundle/manifests/oadp-operator.clusterserviceversion.yaml.tmp bundle/manifests/oadp-operator.clusterserviceversion.yaml
$ git status
On branch mac-sed
Your branch is up to date with 'kaovilai/mac-sed'.
nothing to commit, working tree clean
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, rayfordj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick master |
|
@kaovilai: new pull request created: #1434 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Why the changes were made
sed with /c command on macos do not accept replacement texts, only delete the pattern.
Since we intend on replacing the line, this PR provides an equivalent functionality with
s/instead of/cHow to test the changes made