Skip to content

[oadp-1.4] bundle createdAt sed for macOS#1405

Merged
openshift-merge-bot[bot] merged 4 commits into
openshift:oadp-1.4from
kaovilai:mac-sed
Jun 1, 2024
Merged

[oadp-1.4] bundle createdAt sed for macOS#1405
openshift-merge-bot[bot] merged 4 commits into
openshift:oadp-1.4from
kaovilai:mac-sed

Conversation

@kaovilai
Copy link
Copy Markdown
Member

@kaovilai kaovilai commented May 31, 2024

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Why the changes were made

sed with /c command on macos do not accept replacement texts, only delete the pattern.

Since we intend on replacing the line, this PR provides an equivalent functionality with s/ instead of /c

How to test the changes made

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai
Copy link
Copy Markdown
Member Author

/cc @mateusoliveira43 @weshayutin

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@mateusoliveira43

This comment was marked as resolved.

Comment thread Makefile Outdated
kaovilai and others added 2 commits May 31, 2024 10:17
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai
Copy link
Copy Markdown
Member Author

sed -i'' 's/    createdAt: .*/    createdAt: "2024-05-29T17:22:16Z"/' bundle/manifests/oadp-operator.clusterserviceversion.yaml
sed: 1: "bundle/manifests/oadp-o ...": undefined label 'undle/manifests/oadp-operator.clusterserviceversion.yaml'
make: *** [bundle] Error 1

I'm just gonna avoid in-place and use mv

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Copy link
Copy Markdown
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

$ make bundle
     ----8<----
INFO[0000] All validation tests have completed successfully 
sed -e 's/    createdAt: .*/    createdAt: "2024-05-29T17:22:16Z"/' bundle/manifests/oadp-operator.clusterserviceversion.yaml > bundle/manifests/oadp-operator.clusterserviceversion.yaml.tmp
mv bundle/manifests/oadp-operator.clusterserviceversion.yaml.tmp bundle/manifests/oadp-operator.clusterserviceversion.yaml

$ git status 
On branch mac-sed
Your branch is up to date with 'kaovilai/mac-sed'.

nothing to commit, working tree clean

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, rayfordj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@mateusoliveira43 mateusoliveira43 changed the title bundle createdAt sed for macOS [oadp-1.4] bundle createdAt sed for macOS May 31, 2024
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD e22e87b and 2 for PR HEAD 9071a4f in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD dce032b and 1 for PR HEAD 9071a4f in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 3c33010 and 0 for PR HEAD 9071a4f in total

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2024

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 719b20c into openshift:oadp-1.4 Jun 1, 2024
@kaovilai
Copy link
Copy Markdown
Member Author

/cherry-pick master

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@kaovilai: new pull request created: #1434

Details

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants