Skip to content

fix: Remove velero pkg generated#1492

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
mateusoliveira43:fix/remove-pkg-generated
Aug 15, 2024
Merged

fix: Remove velero pkg generated#1492
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
mateusoliveira43:fix/remove-pkg-generated

Conversation

@mateusoliveira43
Copy link
Copy Markdown

Why the changes were made

Fixes #1221

How to test the changes made

Run E2E tests and check the behavior has not changed.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@openshift-ci openshift-ci Bot requested review from eemcmullan and kaovilai August 14, 2024 14:00
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43
Copy link
Copy Markdown
Author

/retest

@shubham-pampattiwar
Copy link
Copy Markdown
Member

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mateusoliveira43
Copy link
Copy Markdown
Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 15, 2024

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shubham-pampattiwar
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 5084c37 into openshift:master Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re: proposal to remove pkg/generated from velero, remove the dependency from e2e tests

3 participants