Skip to content

OADP-3562: Fix controller panic on secret key-value parsing #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Oct 1, 2024
Merged

OADP-3562: Fix controller panic on secret key-value parsing #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ linters:
# - gosimple
# - govet
# - ineffassign
- loggercheck
# - misspell
- nakedret
# - nilerr
Expand Down
4 changes: 2 additions & 2 deletions controllers/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,8 @@ func (r *DPAReconciler) getMatchedKeyValue(key string, s string) (string, error)
s = strings.TrimPrefix(s, prefix)
}
if len(s) == 0 {
r.Log.Info("Could not parse secret for %s", key)
return s, errors.New(key + " secret parsing error")
r.Log.Info(fmt.Sprintf("Could not parse secret for %s", key))
return s, errors.New("secret parsing error in key " + key)
}
return s, nil
}
Expand Down