Skip to content

OADP-3562: Fix controller panic on secret key-value parsing (#1529)#1549

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:oadp-1.4from
stillalearner:fix_oadp3562_oadp1.4
Oct 9, 2024
Merged

OADP-3562: Fix controller panic on secret key-value parsing (#1529)#1549
openshift-merge-bot[bot] merged 1 commit into
openshift:oadp-1.4from
stillalearner:fix_oadp3562_oadp1.4

Conversation

@stillalearner
Copy link
Copy Markdown
Contributor

@stillalearner stillalearner commented Oct 9, 2024

(cherry picked from commit 5b0b9fc)

Why the changes were made

This is a cherry-pick to oadp-1.4 for OADP-3562: Fix controller panic on secret key-value parsing (#1529)

How to test the changes made

Use make deploy-olm

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 9, 2024

@stillalearner: This pull request references OADP-3562 which is a valid jira issue.

Details

In response to this:

(cherry picked from commit 5b0b9fc)

Why the changes were made

This is a cherry-pick to oadp-1.4 for OADP-3562: Fix controller panic on secret key-value parsing (#1529)

How to test the changes made

Use make deploy-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mateusoliveira43
Copy link
Copy Markdown

/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@mpryc
Copy link
Copy Markdown
Contributor

mpryc commented Oct 9, 2024

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc, stillalearner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD cf0e276 and 2 for PR HEAD 7c1645f in total

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 9, 2024

@stillalearner: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 114a053 into openshift:oadp-1.4 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants