Skip to content

CRD updates for the oc CLI fields for the NAR, NAB and NABSL objects#1709

Merged
weshayutin merged 1 commit into
openshift:masterfrom
mpryc:issue_232_oc_get_fields-v1
Apr 11, 2025
Merged

CRD updates for the oc CLI fields for the NAR, NAB and NABSL objects#1709
weshayutin merged 1 commit into
openshift:masterfrom
mpryc:issue_232_oc_get_fields-v1

Conversation

@mpryc
Copy link
Copy Markdown
Contributor

@mpryc mpryc commented Apr 11, 2025

Why the changes were made

Change required by the migtools/oadp-non-admin#245

How to test the changes made

Deploy and ensure oc cli command is properly showing fields.
Please refer to the migtools/oadp-non-admin#245 (comment)

Change required by the migtools/oadp-non-admin#245

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 11, 2025

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, mpryc, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mateusoliveira43,mpryc,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin weshayutin merged commit f7f0e80 into openshift:master Apr 11, 2025
9 checks passed
@shubham-pampattiwar
Copy link
Copy Markdown
Member

/cherry-pick oadp-1.5

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@shubham-pampattiwar: new pull request created: #1711

Details

In response to this:

/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants