Skip to content

OADP-6500: allow nonadmin.enabled.false#1897

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-devfrom
weshayutin:nonadminfalse
Aug 18, 2025
Merged

OADP-6500: allow nonadmin.enabled.false#1897
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-devfrom
weshayutin:nonadminfalse

Conversation

@weshayutin
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin commented Aug 7, 2025

Why the changes were made

Only one dpa w/ nonadmin.enabled true is allowed. Other DPA's should be allowed to have nonadmin.enabled.false w/o error

How to test the changes made

  • install 2 oadp's in different namespaces
  • set the first to nonadmin.enabled: true
  • Create the second dpa w/ nonadmin.enabled.false
    • you should not see an error.

@weshayutin
OADP-6500: allow nonadmin.enabled.false
434250d 
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 7, 2025 •
edited by openshift-ci Bot
Loading

@weshayutin: This pull request references OADP-6500 which is a valid jira issue.

Details

In response to this:

Why the changes were made

Only one dpa w/ nonadmin.enabled true is allowed. Other DPA's should be allowed to have nonadmin.enabled.false w/o error

How to test the changes made

  • install 2 oadp's in different namespaces
  • set the first to nonadmin.enabled: true
  • Create the second dpa w/ nonadmin.enabled.false
  • you should not see an error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Aug 7, 2025

/cherry-pick oadp-1.5

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

openshift-cherrypick-robot commented Aug 7, 2025

@weshayutin: once the present PR merges, I will cherry-pick it on top of oadp-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from mpryc and sseago August 7, 2025 21:08
kaovilai
kaovilai requested changes Aug 7, 2025
View reviewed changes
Comment thread internal/controller/validator_test.go Outdated
@weshayutin @kaovilai
Update internal/controller/validator_test.go
cec674b 
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2025
@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Aug 13, 2025

/retest

kaovilai
kaovilai approved these changes Aug 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 164bf42 and 2 for PR HEAD cec674b in total

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Aug 13, 2025 •
edited
Loading

hrm.. hcp failing w/

          s: "failed to install operator multicluster-engine: failed to get PackageManifest for operator multicluster-engine: packagemanifests.packages.operators.coreos.com \"multicluster-engine\" not found",

Ah.. this is an optional job anyway :)
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__4.20.yaml#L140-L141

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 164bf42 and 2 for PR HEAD cec674b in total

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 164bf42 and 2 for PR HEAD cec674b in total

@mpryc
Copy link
Copy Markdown
Contributor

mpryc commented Aug 14, 2025

/retest-required

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mpryc,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc
Copy link
Copy Markdown
Contributor

mpryc commented Aug 14, 2025

This may not entirely fix the cli-aws job, but at least it won't fail on velero namespace check:
#1904

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 14, 2025

/retest-required

Remaining retests: 0 against base HEAD d9ff173 and 1 for PR HEAD cec674b in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 14, 2025

/retest-required

Remaining retests: 0 against base HEAD d9ff173 and 2 for PR HEAD cec674b in total

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 14, 2025

/retest-required

Remaining retests: 0 against base HEAD d9ff173 and 2 for PR HEAD cec674b in total

@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Aug 14, 2025

This may not entirely fix the cli-aws job, but at least it won't fail on velero namespace check: #1904

The "failing namespace check" is an err that is printed to stdout and does not cause exit 1, and is not the root cause of ci failure.
#1899 fixes cli-aws job.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 15, 2025

/retest-required

Remaining retests: 0 against base HEAD ea426b0 and 1 for PR HEAD cec674b in total

@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Aug 15, 2025

/retest

1 similar comment
@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Aug 18, 2025

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 18, 2025

/retest-required

Remaining retests: 0 against base HEAD ea426b0 and 2 for PR HEAD cec674b in total

@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Aug 18, 2025

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 18, 2025

@weshayutin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.20-e2e-test-hcp-aws cec674b link false /test 4.20-e2e-test-hcp-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit da56630 into openshift:oadp-dev Aug 18, 2025
13 of 14 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

openshift-cherrypick-robot commented Aug 18, 2025

@weshayutin: new pull request created: #1912

Details

In response to this:

/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaovilai kaovilai kaovilai approved these changes

@mpryc mpryc mpryc approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@sseago sseago Awaiting requested review from sseago

Assignees

@kaovilai kaovilai

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@weshayutin @openshift-ci-robot @openshift-cherrypick-robot @mpryc @kaovilai @shubham-pampattiwar