Use upstream install.Deployment, use secretName from BSL spec for volumeMount/Volume names by kaovilai · Pull Request #234 · openshift/oadp-operator

kaovilai · 2021-08-22T22:15:14Z

Refactored buildVeleroDeployment to use upstream install.Deployment
Blocked by #233 #232 #231
This PR will be base for PR #235 resolving #175

kaovilai · 2021-08-25T15:36:02Z

/test ci/prow/operator-e2e

openshift-ci · 2021-08-25T15:50:52Z

@kaovilai: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test ci-index
/test images
/test operator-e2e

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kaovilai · 2021-08-25T15:52:19Z

/test operator-e2e

Requested changes implemented

change implemented

kaovilai · 2021-08-26T17:14:31Z

wtf
/retest ci-index

openshift-ci · 2021-08-26T17:17:54Z

@kaovilai: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test ci-index
/test images
/test operator-e2e

Use /test all to run all jobs.

Details

In response to this:

wtf
/retest ci-index

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kaovilai · 2021-08-26T17:33:46Z

/test ci-index

dymurray · 2021-08-31T14:44:19Z

+	veleroDeployment.Spec.Replicas = pointer.Int32(1)
+	veleroDeployment.Spec.Template.Spec.Tolerations = velero.Spec.VeleroTolerations
+	veleroDeployment.Spec.Template.Spec.Volumes = append(veleroDeployment.Spec.Template.Spec.Volumes,
+		corev1.Volume{


@shubham-pampattiwar can you remind me, do we need this? I thought maybe we determined this came from an older instance of our installation we no longer needed. Setting this to an emptydir volume doesn't seem to be doing anything... but I can't remember what we said about it.

@dymurray I am not sure if this is needed but would like to keep it for now 😅 , IIRC we removed the certs-* initContainer.

openshift#234 (comment) openshift#234 (comment) openshift#234 (comment) openshift#234 (comment) openshift#234 (comment)

openshift#234 (comment)

openshift-ci Bot requested review from dymurray and shubham-pampattiwar August 22, 2021 22:15

kaovilai mentioned this pull request Aug 22, 2021

Support non file based identity#175 #235

Closed

kaovilai force-pushed the useUpstreamInstallDeploymentFunc branch 3 times, most recently from 8cfaebe to 5a65e08 Compare August 22, 2021 23:05

kaovilai marked this pull request as draft August 23, 2021 16:53

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2021

kaovilai force-pushed the useUpstreamInstallDeploymentFunc branch 2 times, most recently from 5e19572 to 5b34b75 Compare August 23, 2021 18:54

shubham-pampattiwar previously requested changes Aug 23, 2021

View reviewed changes

Comment thread controllers/velero.go

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2021

kaovilai force-pushed the useUpstreamInstallDeploymentFunc branch from 5b34b75 to 285638e Compare August 25, 2021 15:33

kaovilai marked this pull request as ready for review August 25, 2021 15:34

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2021

kaovilai force-pushed the useUpstreamInstallDeploymentFunc branch from 285638e to e5b7b5c Compare August 25, 2021 16:06

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2021

kaovilai force-pushed the useUpstreamInstallDeploymentFunc branch from e5b7b5c to bcd2f1f Compare August 25, 2021 16:46

kaovilai requested a review from shubham-pampattiwar August 25, 2021 17:09

kaovilai force-pushed the useUpstreamInstallDeploymentFunc branch 2 times, most recently from d7e8b68 to 9c7f976 Compare August 25, 2021 17:16

kaovilai changed the title ~~Use upstream install.Deployment~~ Use upstream install.Deployment, use secretName from BSL spec for volumeMount/Volume names Aug 25, 2021

shubham-pampattiwar previously requested changes Aug 26, 2021

View reviewed changes

Comment thread pkg/credentials/credentials.go

kaovilai requested a review from shubham-pampattiwar August 26, 2021 16:04

dymurray reviewed Aug 31, 2021

View reviewed changes

Comment thread controllers/velero.go

dymurray reviewed Aug 31, 2021

View reviewed changes

Comment thread controllers/velero_test.go Outdated

kaovilai added a commit to kaovilai/oadp-operator that referenced this pull request Aug 31, 2021

resolve discussions

48e4a85

openshift#234 (comment) openshift#234 (comment) openshift#234 (comment) openshift#234 (comment) openshift#234 (comment)

kaovilai added 4 commits August 31, 2021 14:18

use upstream install.Deployment

c24045a

nil check for bsl.Credential.Name

a8b9bb2

continue ignore nil check

a1e3c4f

resolve discussions

c291880

openshift#234 (comment) openshift#234 (comment) openshift#234 (comment) openshift#234 (comment) openshift#234 (comment)

kaovilai force-pushed the useUpstreamInstallDeploymentFunc branch from 48e4a85 to c291880 Compare August 31, 2021 18:19

kaovilai requested a review from dymurray August 31, 2021 18:30

kaovilai added 2 commits August 31, 2021 16:52

When you do this please also update the test

bfebabb

openshift#234 (comment)

PullAlways velero iamge

a9e7977

dymurray approved these changes Sep 1, 2021

View reviewed changes

dymurray merged commit e93f9fe into openshift:master Sep 1, 2021

Conversation

kaovilai commented Aug 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kaovilai commented Aug 25, 2021

Uh oh!

openshift-ci Bot commented Aug 25, 2021

Uh oh!

kaovilai commented Aug 25, 2021

Uh oh!

Uh oh!

kaovilai commented Aug 26, 2021

Uh oh!

openshift-ci Bot commented Aug 26, 2021

Uh oh!

kaovilai commented Aug 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dymurray Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

shubham-pampattiwar Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kaovilai commented Aug 22, 2021 •

edited

Loading