Add restore resource priorities configuration option#268
Merged
dymurray merged 4 commits intoSep 10, 2021
Merged
Conversation
openshift-ci
Bot
added
the
needs-rebase
kaovilai
force-pushed
the
addRestoreResourcePrioritiesConfigurationOption
branch
from
8ee4c12 to
87225f6
Compare
openshift-ci
Bot
removed
the
needs-rebase
kaovilai
force-pushed
the
addRestoreResourcePrioritiesConfigurationOption
branch
from
87225f6 to
63f1fb7
Compare
kaovilai
requested review from
dymurray and
shubham-pampattiwar
and removed request for
jmontleon and
sseago
dymurray
approved these changes
Sep 7, 2021
Member
dymurray
left a comment
dymurray
left a comment
There was a problem hiding this comment.
overall LGTM, couple of comments
- add feature flag if restoreResourcesVersionPriority configmap is defined - implemented removeDuplicateValues function
kaovilai
force-pushed
the
addRestoreResourcePrioritiesConfigurationOption
branch
from
5ee1dbb to
4a91333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--featuresif restoreResourcesVersionPriority configmap is defined (does not change user applied velero CR)Closes #176