Skip to content

awk for azure resource group can accept unformatted json#659

Closed
kaovilai wants to merge 2 commits into
openshift:masterfrom
kaovilai:azureResourceGroup
Closed

awk for azure resource group can accept unformatted json#659
kaovilai wants to merge 2 commits into
openshift:masterfrom
kaovilai:azureResourceGroup

Conversation

@kaovilai
Copy link
Copy Markdown
Member

@kaovilai kaovilai commented Apr 30, 2022

Fix #658
Make awk regex used for azure resource group work when input json is an unformatted single line.

@openshift-ci openshift-ci Bot requested review from jwmatthews and mperetzred April 30, 2022 22:14
@kaovilai kaovilai requested review from deepakraj1997 and removed request for jwmatthews April 30, 2022 22:15
@kaovilai
Copy link
Copy Markdown
Member Author

/test-all

@kaovilai
Copy link
Copy Markdown
Member Author

/test 4.7-operator-e2e-azure
/test 4.8-operator-e2e-azure
/test 4.9-operator-e2e-azure
/test 4.10-operator-e2e-azure

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 1, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai changed the title fix awk for azure resource group awk for azure resource group can accept unformatted json May 1, 2022
@deepakraj1997
Copy link
Copy Markdown
Contributor

/lgtm @kaovilai If I remember correctly, It did pass for Azure before and picked up the resource group properly, maybe formatting issue ? Thank you for looking into this!

@kaovilai
Copy link
Copy Markdown
Member Author

kaovilai commented May 2, 2022

Closed in favor of #654. Edit: reopened since it had lgtm.

@kaovilai kaovilai closed this May 2, 2022
@kaovilai
Copy link
Copy Markdown
Member Author

kaovilai commented May 2, 2022

oops didn't see lgtm. :D

@kaovilai kaovilai reopened this May 2, 2022
@kaovilai
Copy link
Copy Markdown
Member Author

kaovilai commented May 2, 2022

maybe formatting issue ?

I think it depends which config files you end up getting which may differ from region/cluster/zones that are outside our control. But sounds like majority of (at least recent) the clusters had unformatted, no newline, json.

@deepakraj1997
Copy link
Copy Markdown
Contributor

Got it. Please close this PR when you see fit since you have already included these in the #654, you might have a clash or need to do a rebase if both goes in.

@kaovilai kaovilai closed this May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Azure E2E using -rg resource group

2 participants