Skip to content

OADP-524, OADP-460 mtc operator type, noDefaultBackupLocation secret handling [1.0 cp] #701 #607#702

Merged
kaovilai merged 5 commits into
openshift:oadp-1.0from
kaovilai:oadp-524-operator-type-1.0cp
May 18, 2022
Merged

OADP-524, OADP-460 mtc operator type, noDefaultBackupLocation secret handling [1.0 cp] #701 #607#702
kaovilai merged 5 commits into
openshift:oadp-1.0from
kaovilai:oadp-524-operator-type-1.0cp

Conversation

@kaovilai
Copy link
Copy Markdown
Member

@kaovilai kaovilai commented May 17, 2022

1.0 cherrypick
#701 OADP-524 mtc operator type
Enables alternative behavior when OADP is consumed by MTC

#607 OADP-460 Don't get secret if NoDefaultBackupLocation

Enables alternative behavior when OADP is consumed by MTC
@openshift-ci openshift-ci Bot requested review from dymurray and pranavgaikwad May 17, 2022 19:56
@kaovilai kaovilai changed the title OADP-524 mtc operator type OADP-524 mtc operator type [1.0 cp] May 17, 2022
Comment thread controllers/validator_test.go Outdated
Comment thread controllers/validator_test.go Outdated
Copy link
Copy Markdown
Member Author

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a cherry-pick error coming from missing cherrypick #607 in 1.0

@kaovilai kaovilai changed the title OADP-524 mtc operator type [1.0 cp] OADP-524 mtc operator type [1.0 cp] #701 #607 May 17, 2022
kaovilai added 2 commits May 17, 2022 16:57
…ges: false (openshift#607)

* Don't getProviderSecret when noDefaultBackupLocation flag set

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* add check that when NoDefaultBackupLocation is set, dpa.Spec.BackupImages is false

Use BackupImages functions when checking conditions

* fix test case
@kaovilai kaovilai requested a review from dymurray May 17, 2022 21:03
@kaovilai kaovilai changed the title OADP-524 mtc operator type [1.0 cp] #701 #607 OADP-524 mtc operator type, noDefaultBackupLocation secret handling [1.0 cp] #701 #607 May 17, 2022
@kaovilai kaovilai changed the title OADP-524 mtc operator type, noDefaultBackupLocation secret handling [1.0 cp] #701 #607 OADP-524, OADP-460 mtc operator type, noDefaultBackupLocation secret handling [1.0 cp] #701 #607 May 17, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 17, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit cea8221 into openshift:oadp-1.0 May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants