fixing http/s proxy handling for openshift provider

[patlachance]

Fixes #71

[openshift-ci-robot]

Hi @patlachance. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pgier]

/ok-to-test

[mrogers950]

We should modify the transport for this outside of the setCA function.

[patlachance]

http_proxy and https_proxy environment variables are handled by http.DefaultTransport. This function is used to set custom CA on the transport but IMO it shouldn't discard other http.DefaultTransport default properties. But this is what is does since we need to change it later so it handle proxy env variables again.

I couldn't find a way to extend the p.client.transport outside this function without having to define the custom CA as well in the new function.

Any idea how to do it?

[brancz]

@openshift/sig-auth

[mrogers950]

@patlachance please modify your patch to set the transport proxy outside of setCA() (after it's called in LoadDefaults()). That's my only feedback and then we will be OK to merge.

[patlachance]

@mrogers950 please see comment on your review. Don't know how to do it without managing custom CA at the same time.

[mrogers950]

@patlachance sorry for the delay, I see what you're saying about setting the transport here. If you can also change the function name to setCAandTransportProxy or similar, that would be acceptable, just to make it clear that the function is doing both of these things.

[patlachance]

@mrogers950 ok I’ll do it over the weekend.

[mrogers950]

/test all

[mrogers950]

@patlachance I'm still waiting on your fixup. I'd be willing to open a separate PR and push the fix through myself if you have not had the time to return to this, just let me know.

[patlachance]

@mrogers950 sorry for the delay. Done now!

[openshift-ci-robot]

@patlachance: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

@mrogers950 sorry for the delay. Done now!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mrogers950]

@patlachance looks good, thank you for your contribution!
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrogers950, patlachance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mrogers950]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mrogers950]

/ok-to-test

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.