`oc version` format inconsistent between external download and console download

[chrisbygrave]

If I download an oc binary here and run oc version I get:

Client Version: 4.5.7
Server Version: 4.5.7
Kubernetes Version: v1.18.3+2cf11e2

However if I pull the binary from the OpenShift console of a 4.5.7 server and run oc version I see:

Client Version: openshift-clients-4.5.0-202006231303.p0-4-gb66f2d3a6
Server Version: 4.5.7
Kubernetes Version: v1.18.3+2cf11e2

This makes scripting with oc more complicated. What's the reason for a non-semver client version field in the binary downloaded from the OpenShift console?

[fckbo]

Hello,

sorry I looked at this a bit more and with oc downloaded from here (https://cloud.redhat.com/openshift/install/vsphere/user-provisioned)

oc version -o yaml

on my system, it gives this:

./oc version -o yaml --client
clientVersion:
  buildDate: "2020-09-04T14:31:27Z"
  compiler: gc
  gitCommit: e40bd2dd95be1106ead550990c549f932752b239
  gitTreeState: clean
  gitVersion: openshift-clients-4.5.0-202006231303.p0-9-ge40bd2dd9
  goVersion: go1.13.4
  major: ""
  minor: ""
  platform: darwin/amd64
releaseClientVersion: 4.5.9

Then downloading the client from the oc console (which in fact consist in getting it from https://mirror.openshift.com/pub/openshift-v4/clients/oc/4.x for OCP 4.x)it gives:

• for version 4.2:

./oc version -o yaml --client
clientVersion:
  buildDate: "2020-05-02T06:42:03Z"
  compiler: gc
  gitCommit: 1337b299ce122ba5f4d38fa6d8aea1ca202fd009
  gitTreeState: clean
  gitVersion: 4.2.32-202005020632-1337b29
  goVersion: go1.12.8
  major: ""
  minor: ""
  platform: darwin/amd64

• and for version 4.5:

./oc version -o yaml --client
clientVersion:
  buildDate: "2020-05-29T14:25:45Z"
  compiler: gc
  gitCommit: 9933eb90790b36d153fcc55f8404724bb0929b96
  gitTreeState: clean
  gitVersion: 4.5.0-202005291417-9933eb9
  goVersion: go1.13.4
  major: ""
  minor: ""
  platform: darwin/amd64

So the releaseClientVersion is not displayed and when running it without -o yaml option, it looks like the gitVersion is displayed...

This is confirmed to be done intentionally here version.go

		if versionInfo.ClientVersion != nil {
			if len(versionInfo.ReleaseClientVersion) != 0 {
				fmt.Fprintf(o.Out, "Client Version: %s\n", reportedVersion)
			} else {
				fmt.Fprintf(o.Out, "Client Version: %s\n", clientVersion.GitVersion)
			}
		}

The reportedVersion apparently comes the ExtractVersion function in this file and in the case of the oc version downloaded from the mirror it returns "".

I'm sorry because this does not explain why these two different behaviours are observed and thus does not really answer your issue but hopefully someone will step up to explain why these were implemented...

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.