pkg/cli/admin/upgrade: Mention channel choices#1088

Merged

openshift-merge-robot merged 1 commit intoopenshift:masterfrom

wking:discoverable-help-oc-adm-upgrade-channel

Mar 17, 2022

Member

wking commented Mar 16, 2022

Making it easier for folks to find the oc adm upgrade channel subcommand from 4b8f0fd (#576), when they look at oc adm --help.

openshift-ci bot requested review from smarterclayton and soltysh

March 16, 2022 17:07

openshift-ci bot added the approved label

LalatenduMohanty suggested changes

View reviewed changes

pkg/cli/admin/upgrade/upgrade.go Outdated Show resolved Hide resolved


          pkg/cli/admin/upgrade: Mention channel choices

0e9e0bf

Making it easier for folks to find the 'oc adm upgrade channel'
subcommand from 4b8f0fd (pkg/cli/admin/upgrade/channel: Add 'oc adm
upgrade channel ...', 2022-03-16, openshift#576), when they look at 'oc adm
--help'.

wking force-pushed the discoverable-help-oc-adm-upgrade-channel branch from 84daf9f to 0e9e0bf Compare

March 16, 2022 22:05

LalatenduMohanty approved these changes

View reviewed changes

Member

LalatenduMohanty left a comment

/lgtm

openshift-ci bot assigned LalatenduMohanty

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Mar 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/cli/admin/upgrade/OWNERS~~ [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci bot commented Mar 17, 2022

@wking: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	`0e9e0bf`	link	false	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit e8f33b3 into openshift:master

wking deleted the discoverable-help-oc-adm-upgrade-channel branch

March 17, 2022 03:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels