Bug 1759185: clarify upgrade's force flag description #121
Conversation
|
@soltysh: This pull request references Bugzilla bug 1759185, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@soltysh: This pull request references Bugzilla bug 1759185, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
pkg/cli/admin/upgrade/upgrade.go
Outdated
| flags.BoolVar(&o.ToLatestAvailable, "to-latest", o.ToLatestAvailable, "Use the next available version") | ||
| flags.BoolVar(&o.Clear, "clear", o.Clear, "If an upgrade has been requested but not yet downloaded, cancel the update. This has no effect once the update has started.") | ||
| flags.BoolVar(&o.Force, "force", o.Force, "Upgrade even if an upgrade is in process or other error is blocking update.") | ||
| flags.BoolVar(&o.Force, "force", o.Force, "Try forcully upgrade the cluster but check for upgrade possibility.") |
There was a problem hiding this comment.
Suggested wording: Forcefully upgrade the cluster even when upgrade release image validation fails.
|
It's missing the part on "if the cluster is. reporting errors" |
|
@smarterclayton updated, ptal |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@soltysh: All pull requests linked via external trackers have merged. Bugzilla bug 1759185 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Followup from #109.
/assign @smarterclayton
cc @mffiedler