pkg/cli/admin/upgrade: Drop "force" from "No updates available"#1291
Conversation
openshift-ci
Bot
added
the
approved
The outgoing wording dates back to the initial subcommand implementation in openshift/origin@65cce8c37d (Add `oc adm upgrade` to display available updates or trigger an update, 2018-12-04, openshift/origin#21605). But "force" is easy to conflate with the --force option, and we occasionally hear of users who set --force under the mistaken impression that it is related to the recommended-ness of the target release image. This message is only rendered when availableUpdates is empty, so --to-image is unlikely to be sufficient. The current output will be: $ oc adm upgrade --to-image quay.io/openshift-release-dev/ocp-release@sha256:20e270c3349fe2fcb38fd0da155329babc02d6b53e7e06ff235346c3c1cf11b5 error: no recommended updates, specify --allow-explicit-upgrade to continue with the update or wait for new updates to be available. which we could stiffen up by including some of --help's current warnings about --allow-explicit-upgrade risk, but we can address that in follow-up work.
wking
force-pushed
the
non-recommended-updates-do-not-require-force
branch
from
1ea7a9d to
bdccf16
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ci/prow/e2e-aws-ovn-upgrade |
|
@wking: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-ovn-upgrade |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
The outgoing wording dates back to the initial subcommand implementation in openshift/origin@65cce8c37d (openshift/origin#21605). But "force" is easy to conflate with the
--forceoption, and we occasionally hear of users who set--forceunder the mistaken impression that it is related to the recommended-ness of the target release image. There's already a paragraph in the generic--helptext discussing the risks of--allow-explicit-upgrade, and folks who use--to-imagein the absence of recommended updates will hear about--allow-explicit-upgradewhen a bare--to-imagefails to turn up the requested pullspec inavailableUpdates.