Skip to content

Bug 1778807: Update support tools container image #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

Bug 1778807: Update support tools container image #197

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 2, 2019

This is an automated cherry-pick of #185

/assign crawford

@crawford
debug: update support tools container image
6a93ada 
The RHEL7 support tools image is only built for AMD64, but there will
soon be a need for an image that works on System Z (and eventually
Power). Changing to the RHEL8 image gets us the additional
architectures. Additionally, RHCOS has moved to RHEL8 content, so it's
best to keep the support tools in sync.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 2, 2019
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1777030, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Bug 1777030: Update support tools container image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2019
@crawford
Copy link
Contributor

crawford commented Dec 2, 2019

/retitle Bug 1777031: Update support tools container image

@openshift-ci-robot openshift-ci-robot changed the title [release-4.2] Bug 1777030: Update support tools container image Bug 1777031: Update support tools container image Dec 2, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1777031, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.3.0" instead
  • expected dependent Bugzilla bug 1777030 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1777031: Update support tools container image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford
Copy link
Contributor

crawford commented Dec 2, 2019

Oops, wrong PR.

/retitle Bug 1778807: Update support tools container image

@openshift-ci-robot openshift-ci-robot changed the title Bug 1777031: Update support tools container image Bug 1778807: Update support tools container image Dec 2, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1778807, which is invalid:

  • expected dependent Bugzilla bug 1777031 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1778807: Update support tools container image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
until we solve the 4.2 problems

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 2, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@crawford
Copy link
Contributor

crawford commented Dec 2, 2019

/retest

@crawford
Copy link
Contributor

crawford commented Dec 2, 2019

The unit tests are passing again 🎉

We still need to wait for QE to verify the 4.3 version before this can merge, but in the meantime...

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019
@crawford
Copy link
Contributor

crawford commented Dec 3, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 3, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2019

@crawford: This pull request references Bugzilla bug 1778807, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 3, 2019
@crawford
Copy link
Contributor

crawford commented Dec 4, 2019

Apparently we can't support RHEL8 container images on RHEL7 nodes, so this isn't going to work on RHEL7 workers.

@crawford crawford closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crawford crawford

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @crawford @soltysh