Skip to content

Bug 1779332: Fix a number of issues around debugging daemonset pods and init containers #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Dec 5, 2019
Merged

Bug 1779332: Fix a number of issues around debugging daemonset pods and init containers #200

openshift-merge-robot merged 5 commits into from
Dec 5, 2019

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 3, 2019

This is an automated cherry-pick of #166

/assign soltysh

@smarterclayton
debug: Allow the object to be targeted at another namespace
8bda514 
When using `oc debug istag/foo:bar` it is not uncommon to want to
create the debug pod in another namespace. Make that possible by
adding `--to-namespace` which overrides the pod namespace.
@smarterclayton
debug: Clear initContainers when --one-container
c9d1344 
The implication of --one-container is that we only want a single
container.
@smarterclayton
debug: Print init containers in the list of suggested container names
2bcf04f 
We only printed the regular container names.
@smarterclayton
debug: When debugging an init container, don't clear it immediately
8469a05 
If a user specifies an init container, we have to preserve it even
if `--keep-init-containers=false` is set. In that case, we strip
all other init containers.
@smarterclayton
debug: Clear host ports when debugging a pod
8d3db77 
If there is a host port set, clear it. If this is a host network pod,
clear all ports. This allows us to debug a pod on the same node for
daemonsets that declare host network or host pods.
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 3, 2019
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 3, 2019
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1779331, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1779331: Fix a number of issues around debugging daemonset pods and init containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 3, 2019
@smarterclayton smarterclayton changed the title [release-4.3] Bug 1779331: Fix a number of issues around debugging daemonset pods and init containers Bug 1779331: Fix a number of issues around debugging daemonset pods and init containers Dec 3, 2019
@smarterclayton smarterclayton changed the title Bug 1779331: Fix a number of issues around debugging daemonset pods and init containers Bug 1779333: Fix a number of issues around debugging daemonset pods and init containers Dec 3, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1779333, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1779333: Fix a number of issues around debugging daemonset pods and init containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton smarterclayton changed the title Bug 1779333: Fix a number of issues around debugging daemonset pods and init containers Bug 1779332: Fix a number of issues around debugging daemonset pods and init containers Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 3, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1779332, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1779332: Fix a number of issues around debugging daemonset pods and init containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link
Contributor

smarterclayton commented Dec 3, 2019

/assign @soltysh

soltysh
soltysh approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3fa38ed into openshift:release-4.3 Dec 5, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2019

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1779332 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1779332: Fix a number of issues around debugging daemonset pods and init containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @smarterclayton @openshift-bot @soltysh @openshift-merge-robot