Skip to content

Bug 1790537: pkg/cli/admin/release/extract_tools: Inject release version into installer #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 4, 2020
Merged

Bug 1790537: pkg/cli/admin/release/extract_tools: Inject release version into installer #249

openshift-merge-robot merged 1 commit into from
Feb 4, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 13, 2020

This is an automated cherry-pick of #165

/assign sdodson

@wking
pkg/cli/admin/release/extract_tools: Inject release version into inst…
300b063 
…aller

We've been injecting the release version into oc since 13215d7 (Bug
1715001: when extracting tools from payload, 'oc version' should
report payload version, 2019-09-10, openshift#88), but we want to inject it
into the installer to to avoid potential confusion from:

  $ oc adm release extract --command=openshift-install quay.io/openshift-release-dev/ocp-release:4.2.7
  $ ./openshift-install version
  ./openshift-install v4.2.5
  built from commit 425e4ff0037487e32571258640b39f56d5ee5572
  release image quay.io/openshift-release-dev/ocp-release@sha256:bac62983757570b9b8f8bc84c740782984a255c16372b3e30cfc8b52c0a187b9
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 13, 2020
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1773257, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.3] Bug 1773257: pkg/cli/admin/release/extract_tools: Inject release version into installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2020
@wking
Copy link
Member

wking commented Jan 13, 2020

/retitle Bug 1790537: pkg/cli/admin/release/extract_tools: Inject release version into installer

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1773257: pkg/cli/admin/release/extract_tools: Inject release version into installer Bug 1790537: pkg/cli/admin/release/extract_tools: Inject release version into installer Jan 13, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1790537, which is invalid:

  • expected dependent Bugzilla bug 1773257 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1790537: pkg/cli/admin/release/extract_tools: Inject release version into installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@soltysh
Copy link
Contributor

soltysh commented Jan 13, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jan 13, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2020

@sdodson: This pull request references Bugzilla bug 1790537, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 13, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jan 14, 2020

We've moved the bug to 4.3.z.
/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 14, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2020

@sdodson: This pull request references Bugzilla bug 1790537, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

We've moved the bug to 4.3.z.
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 14, 2020
@sdodson
Copy link
Member

sdodson commented Jan 24, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 24, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 24, 2020

@sdodson: This pull request references Bugzilla bug 1790537, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 24, 2020
@eparis
Copy link
Member

eparis commented Feb 4, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2020

@eparis: This pull request references Bugzilla bug 1790537, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2e9247f into openshift:release-4.3 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdodson sdodson

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @wking @soltysh @openshift-bot @sdodson @eparis @openshift-merge-robot