Bug 1794606: Use polymorphic helpers from exec, when reading a pod #260

soltysh · 2020-01-16T16:25:21Z

Additionally, this deprecates special case --timeout flag in oc rsh in favour of the global --request-timeout flag.

/assign @sallyom

sallyom · 2020-01-16T18:28:37Z

pkg/cli/rsh/rsh.go


 var (
+	rshUsageStr    = "rsh (POD | TYPE/NAME) COMMAND [ARG1] [ARG2] ... [ARGN]"
+	rshUsageErrStr = fmt.Sprintf("expected '%s'.\nPOD or TYPE/NAME is a required argument for the logs command", rshUsageStr)


for the rsh command : )

sallyom

need to fix the error message %s/logs/rsh
then lgtm

soltysh · 2020-01-20T11:36:29Z

/retest

soltysh · 2020-01-28T15:51:59Z

/retest

openshift-ci-robot · 2020-01-28T15:53:45Z

@soltysh: This pull request references Bugzilla bug 1794606, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1794606: Use polymorphic helpers from exec, when reading a pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sallyom · 2020-01-28T16:08:14Z

/lgtm

openshift-ci-robot · 2020-01-28T16:14:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-29T08:43:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T08:56:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T12:49:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T13:29:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T14:48:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T14:59:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T17:48:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T22:34:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T22:47:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Miciah · 2020-01-30T00:08:52Z

pkg/cli/rsh/rsh.go

+	cmd.Flags().BoolVarP(&options.DisableTTY, "no-tty", "T", options.DisableTTY, "Disable pseudo-terminal allocation")
+	cmd.Flags().StringVar(&options.Executable, "shell", options.Executable, "Path to the shell command")
+	cmd.Flags().IntVar(&options.Timeout, "timeout", options.Timeout, "Request timeout for obtaining a pod from the server; defaults to 10 seconds")
+	cmd.Flags().MarkDeprecated("timeout", "use --request-timeout, instead.")


Shouldn't that be "use --pod-running-timeout"?

Nope, this timeout was using when getting the pod in the old machanism.

openshift-bot · 2020-01-30T01:36:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T01:50:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T03:33:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T03:46:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T05:16:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T05:29:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T07:27:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T07:40:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T09:11:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T09:24:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T10:42:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T11:09:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T12:26:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T12:39:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T21:21:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T23:24:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T23:31:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-31T01:23:31Z

@soltysh: All pull requests linked via external trackers have merged. Bugzilla bug 1794606 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1794606: Use polymorphic helpers from exec, when reading a pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned sallyom Jan 16, 2020

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2020

soltysh mentioned this pull request Jan 16, 2020

OCP 4.4 Release Notes Tracker openshift/openshift-docs#18426

Closed

openshift-ci-robot requested review from deads2k and smarterclayton January 16, 2020 16:26

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020

sallyom reviewed Jan 16, 2020

View reviewed changes

sallyom suggested changes Jan 16, 2020

View reviewed changes

soltysh force-pushed the rsh_polymorphichelpers branch from 7e5c8ae to 9699532 Compare January 17, 2020 12:07

soltysh added 2 commits January 20, 2020 16:42

Use polymorphic helpers from exec, when reading a pod

cb05682

Generated changes

5378c62

soltysh force-pushed the rsh_polymorphichelpers branch from 9699532 to 5378c62 Compare January 20, 2020 15:44

soltysh mentioned this pull request Jan 20, 2020

Loosen help tests for oc rsh openshift/origin#24420

Merged

soltysh changed the title ~~Use polymorphic helpers from exec, when reading a pod~~ Bug 1794606: Use polymorphic helpers from exec, when reading a pod Jan 28, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020

Miciah reviewed Jan 30, 2020

View reviewed changes

openshift-merge-robot merged commit 7097318 into openshift:master Jan 31, 2020

soltysh deleted the rsh_polymorphichelpers branch January 31, 2020 09:15

soltysh mentioned this pull request Feb 12, 2020

Bug 1802262: Use polymorphic helpers from exec, when reading a pod #294

Merged

soltysh mentioned this pull request Jan 22, 2021

OCP 4.7 Release Notes Tracker openshift/openshift-docs#26801

Closed

Bug 1794606: Use polymorphic helpers from exec, when reading a pod #260

Bug 1794606: Use polymorphic helpers from exec, when reading a pod #260

Uh oh!

Conversation

soltysh commented Jan 16, 2020

Uh oh!

sallyom Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

sallyom left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh commented Jan 20, 2020

Uh oh!

soltysh commented Jan 28, 2020

Uh oh!

openshift-ci-robot commented Jan 28, 2020

Uh oh!

sallyom commented Jan 28, 2020

Uh oh!

openshift-ci-robot commented Jan 28, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

Miciah Jan 30, 2020

Choose a reason for hiding this comment

Uh oh!

soltysh Feb 11, 2020

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!