Skip to content

Bug 1801064: Add '\n' for pipeline deprecate info #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 19, 2020
Merged

Bug 1801064: Add '\n' for pipeline deprecate info #299

openshift-merge-robot merged 1 commit into from
Feb 19, 2020

Conversation

@wewang58
Copy link
Contributor

@wewang58 wewang58 commented Feb 17, 2020

/assign @adambkaplan

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2020

@wewang58: This pull request references Bugzilla bug 1801064, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1801064: Add \n for pipeline deprecate info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2020
@wewang58 wewang58 changed the title Bug 1801064: Add \n for pipeline deprecate info Bug 1801064: Add '\n' for pipeline deprecate info Feb 17, 2020
@wewang58
Copy link
Contributor Author

wewang58 commented Feb 17, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 17, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2020

@wewang58: This pull request references Bugzilla bug 1801064, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 17, 2020
@adambkaplan
Copy link
Contributor

adambkaplan commented Feb 18, 2020

@soltysh is there a reason the newline is not needed in https://github.com/openshift/oc/blob/master/pkg/cli/rollout/latest.go#L114 ?

soltysh
soltysh suggested changes Feb 18, 2020
View reviewed changes
pkg/cli/newapp/newapp.go Outdated
case *buildv1.BuildConfig:
if t.Spec.Strategy.Type == buildv1.JenkinsPipelineBuildStrategyType {
fmt.Fprintf(o.Action.ErrOut, "JenkinsPipeline build strategy is deprecated. Use Jenkinsfiles directly on Jenkins or OpenShift Pipelines instead")
fmt.Fprintf(o.Action.ErrOut, "JenkinsPipeline build strategy is deprecated. Use Jenkinsfiles directly on Jenkins or OpenShift Pipelines instead\n")
Copy link
Contributor

@soltysh soltysh Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use fmt.Fprintln instead of manually adding the newline.

Copy link
Contributor Author

@wewang58 wewang58 Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh Updated it, thanks

@soltysh
Copy link
Contributor

soltysh commented Feb 18, 2020

@soltysh is there a reason the newline is not needed in https://github.com/openshift/oc/blob/master/pkg/cli/rollout/latest.go#L114 ?

With Fprintf you're responsible for formatting, that's why I propose to use Fprintln my bad I didn't catch it in your PR.

adambkaplan
adambkaplan approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

build test failed to acquire lease - bots should be able to retest.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, wewang58

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8fabc56 into openshift:master Feb 19, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2020

@wewang58: All pull requests linked via external trackers have merged. Bugzilla bug 1801064 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1801064: Add '\n' for pipeline deprecate info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

adambkaplan commented Feb 20, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 20, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 20, 2020

@adambkaplan: new pull request created: #309

Details

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

+1 more reviewer

@soltysh soltysh soltysh requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wewang58 @openshift-ci-robot @adambkaplan @soltysh @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot