-
Notifications
You must be signed in to change notification settings - Fork 427
Bug 1800674: Option to force RepoDigest mirror #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently `oc image mirror`, when pointed at a manifest list digest, checks the contents of the manifest and mirrors just the underlying image if it contains only a single image. This change adds an option to mirroring to force the repodigest to mirror in addition to the underlying image digest. Additionally, it forces `oc adm catalog mirror` to always enable this option since the repodigest is what is encoded into the OLM manifests. https://bugzilla.redhat.com/show_bug.cgi?id=1800674
|
@benluddy: This pull request references Bugzilla bug 1800674, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @benluddy. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This can be closed if the change in #298 can wait another day. |
|
There's one additional comment that needs fixing in the other PR. |
|
@soltysh: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently
oc image mirror, when pointed at a manifest list digest,checks the contents of the manifest and mirrors just the
underlying image if it contains only a single image.
This change adds an option to mirroring to force the repodigest to
mirror in addition to the underlying image digest. Additionally, it
forces
oc adm catalog mirrorto always enable this option sincethe repodigest is what is encoded into the OLM manifests.
https://bugzilla.redhat.com/show_bug.cgi?id=1800674