Skip to content

Bug 1800464: fix(catalog): use registry image from openshift quay namespace #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 27, 2020
Merged

Bug 1800464: fix(catalog): use registry image from openshift quay namespace #303

openshift-merge-robot merged 1 commit into from
Feb 27, 2020

Conversation

@njhale
Copy link
Contributor

@njhale njhale commented Feb 19, 2020

Updates the default image used in the --from option of oc adm catalog build to the official mirror.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2020

@njhale: This pull request references Bugzilla bug 1800464, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1800464: fix(catalog): use registry image from openshift quay namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2020
@njhale
Copy link
Contributor Author

njhale commented Feb 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 19, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2020

@njhale: This pull request references Bugzilla bug 1800464, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 19, 2020
@njhale
Copy link
Contributor Author

njhale commented Feb 19, 2020

/retest

1 similar comment
@njhale
Copy link
Contributor Author

njhale commented Feb 19, 2020

/retest

ecordell
ecordell reviewed Feb 20, 2020
View reviewed changes
pkg/cli/admin/catalog/build.go Outdated
func NewBuildImageOptions(streams genericclioptions.IOStreams) *BuildImageOptions {
// Adjust default build opts to use an OpenShift base "from" image
defaults := appregistry.DefaultAppregistryBuildOptions()
defaults.From = "quay.io/openshift/origin-operator-registry:latest"
Copy link
Contributor

@ecordell ecordell Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a constant at the top?

Copy link
Contributor Author

@njhale njhale Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll go ahead and update that.

It seems like `e2e-aws-upgrade is consistently failing -- think it might be related?

@ecordell
Copy link
Contributor

ecordell commented Feb 21, 2020

/retest

@ecordell
Copy link
Contributor

ecordell commented Feb 21, 2020

/lgtm

@ecordell
Copy link
Contributor

ecordell commented Feb 21, 2020

/retest

4 similar comments
@ecordell
Copy link
Contributor

ecordell commented Feb 21, 2020

/retest

@ecordell
Copy link
Contributor

ecordell commented Feb 22, 2020

/retest

@ecordell
Copy link
Contributor

ecordell commented Feb 22, 2020

/retest

@ecordell
Copy link
Contributor

ecordell commented Feb 23, 2020

/retest

soltysh
soltysh approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 91563ac into openshift:master Feb 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2020

@njhale: All pull requests linked via external trackers have merged. Bugzilla bug 1800464 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1800464: fix(catalog): use registry image from openshift quay namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Contributor

ecordell commented Feb 27, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 27, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 27, 2020

@ecordell: new pull request created: #326

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

2 more reviewers

@ecordell ecordell ecordell left review comments

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@njhale @openshift-ci-robot @ecordell @openshift-bot @openshift-cherrypick-robot @soltysh @openshift-merge-robot