Skip to content

[release-4.3] Bug 1804463: Option to force RepoDigest mirror #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 27, 2020
Merged

[release-4.3] Bug 1804463: Option to force RepoDigest mirror #313

openshift-merge-robot merged 1 commit into from
Feb 27, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 21, 2020

This is an automated cherry-pick of #304

/assign ecordell

@kevinrizza
Bug 1800674: Option to force RepoDigest mirror
e6cc680 
Currently `oc image mirror`, when pointed at a
manifest list digest, checks the contents of the manifest and mirrors
just the underlying image if it contains only a single image.

This change adds an option to mirroring to force the repodigest to
mirror in addition to the underlying image digest. Additionally, it
forces `oc image mirror` and `oc adm catalog mirror` to always
enable this option

https://bugzilla.redhat.com/show_bug.cgi?id=1800674
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 21, 2020
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1804600, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 1800674 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] [release-4.4] Bug 1804600: Option to force RepoDigest mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2020
@kevinrizza kevinrizza mentioned this pull request Feb 21, 2020
Closed
@ecordell
Copy link
Contributor

ecordell commented Feb 21, 2020

@soltysh Could you set the title to "[release-4.3] Bug 1804463: ..." to pick up the correct bug?

@ecordell
Copy link
Contributor

ecordell commented Feb 21, 2020

/retest

@soltysh
Copy link
Contributor

soltysh commented Feb 21, 2020

@soltysh Could you set the title to "[release-4.3] Bug 1804463: ..." to pick up the correct bug?

/ retitle bot should work just fine here, but changing...

@soltysh soltysh changed the title [release-4.3] [release-4.4] Bug 1804600: Option to force RepoDigest mirror [release-4.3] Bug 1804463: Option to force RepoDigest mirror Feb 21, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1804463, which is invalid:

  • expected dependent Bugzilla bug 1804600 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1804463: Option to force RepoDigest mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@soltysh
Copy link
Contributor

soltysh commented Feb 21, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@kevinrizza
Copy link
Member

kevinrizza commented Feb 25, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 25, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 25, 2020

@kevinrizza: This pull request references Bugzilla bug 1804463, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 25, 2020
@ecordell
Copy link
Contributor

ecordell commented Feb 26, 2020

This is critical for making image mirroring work in 4.3 with multi-arch images.

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 27, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 262a65a into openshift:release-4.3 Feb 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1804463 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1804463: Option to force RepoDigest mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ecordell ecordell

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @ecordell @soltysh @kevinrizza @openshift-bot @knobunc @openshift-merge-robot