Skip to content

Conversation

@pweil-
Copy link

@pweil- pweil- commented Feb 24, 2020

Complete gives error error: you must specify at least one source image to pull and the destination to push to as SRC=DST or SRC DST [DST2 DST3 ...] if only --from-dir is specified even though it is supposed to override --dir.

This adds the override logic to Complete like what happens during Run().plan.Repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2020
@pweil-
Copy link
Author

pweil- commented Feb 24, 2020

/cc @sjenning

@pweil-
Copy link
Author

pweil- commented Feb 24, 2020

for any interested party, this was found testing air-gapped mirroring with the steps here: https://gist.github.com/pweil-/e7b156476c6171f04140370708f0cd56

Using --dir instead of --from-dir works fine so I don't think this is necessarily a backport candidate.

@pweil-
Copy link
Author

pweil- commented Feb 25, 2020

/retest

1 similar comment
@pweil-
Copy link
Author

pweil- commented Feb 26, 2020

/retest

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pweil-, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f0f5994 into openshift:master Feb 26, 2020
@pweil-
Copy link
Author

pweil- commented Feb 27, 2020

/cherry-pick 4.4

@openshift-cherrypick-robot

@pweil-: cannot checkout 4.4: error checking out 4.4: exit status 1. output: error: pathspec '4.4' did not match any file(s) known to git.

Details

In response to this:

/cherry-pick 4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pweil-
Copy link
Author

pweil- commented Feb 27, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@pweil-: new pull request created: #324

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pweil-
Copy link
Author

pweil- commented Feb 27, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@pweil-: new pull request created: #325

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pweil- pweil- changed the title override FileDir with FromFileDir if set in Complete Bug 1807807: override FileDir with FromFileDir if set in Complete Feb 27, 2020
@openshift-ci-robot
Copy link

@pweil-: All pull requests linked via external trackers have merged. Bugzilla bug 1807807 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1807807: override FileDir with FromFileDir if set in Complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants