Bug 1806779: Allow a file:// release argument to release mirror #320
Conversation
|
@smarterclayton: This pull request references Bugzilla bug 1806779, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@smarterclayton: This pull request references Bugzilla bug 1806779, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
|
/assign @wking Found these while reviewing the documentation and fielding questions from folks trying the offline mode. |
|
/cherry-pick release-4.4 |
openshift-ci-robot
added
the
approved
|
@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
4.4 bug is 1806780 and 4.3 bug is 1806782 |
When a file:// argument is provided as the source for oc adm release mirror, do a digest lookup within that repo for any image referenced by the payload, and if found use the local directory as the source. This allows releases to be mirrored to disk and then oc adm release mirror to be used to push it back with: oc adm release mirror file://openshift/release:4.3.1 --to REPO where before it would fail with "invalid image reference". Ensure that when file:// is used the correct instructions are printed for mirroring. Fix the mirror command provided to users to put the wildcard in quotes (to avoid bash shell expansion).
smarterclayton
force-pushed
the
release_offline
branch
from
3552d32 to
e68485f
Compare
|
/retest |
1 similar comment
|
/retest |
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
One question, but this lgtm
/lgtm
| if len(o.From) > 0 { | ||
| src := o.From | ||
| srcRef, err := imagereference.Parse(src) | ||
| srcRef, err := imagesource.ParseReference(src) |
There was a problem hiding this comment.
This will also allow s3:// reference, not sure if you want to allow that?
There was a problem hiding this comment.
I think we do at some point, just haven't gotten a chance to get back to it. We're keeping the s3 in our pocket so we can mirror to static stuff like file. In theory s3 and file should always work everywhere.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smarterclayton: All pull requests linked via external trackers have merged. Bugzilla bug 1806779 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@smarterclayton: new pull request created: #327 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@smarterclayton: new pull request created: #328 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
When a file:// argument is provided as the source for oc adm release
mirror, do a digest lookup within that repo for any image referenced
by the payload, and if found use the local directory as the source.
This allows releases to be mirrored to disk and then oc adm release
mirror to be used to push it back with:
where before it would fail with "invalid image reference".
Ensure that when file:// is used the correct instructions are printed
for mirroring.
Fix the mirror command provided to users to put the wildcard in
quotes (to avoid bash shell expansion).