release: Perform release extract in parallel #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the different repositories in parallel for better performance. Did not add a flag for now because the operation is heavily i/o bound. Also improved output so that we print the path of the repository we extract for use with other tools. $ oc adm release extract --git ... 4.2.2 .../openshift/origin .../openshift/cluster-networking-operator etc.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Allows someone to get the list of repos and commits from a release quickly. Will be used for automation around tagging a commit within a repo.
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
wking
pushed a commit
to wking/oc
that referenced
this pull request
Jun 1, 2020
The command fails when specifying a non-default from directory because the from directory was not passed to either extract or mirror. Add that transformation. Also include the Parallel options as good practice even if they are not heavily used in these flows. Backporting e1567dd (openshift#424) and resolving a context conflict because 4.4 does not include 2725cfa (release: Support `-o commit` on `oc adm release extract --git`, 2020-03-26, openshift#358).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the different repositories in parallel for better performance.
Did not add a flag for now because the operation is heavily i/o
bound. Also improved output so that we print the path of the repository
we extract for use with other tools.
$ oc adm release extract --git ... 4.2.2
.../openshift/origin
.../openshift/cluster-networking-operator
etc.