Skip to content

Bug 1806782: Allow a file:// release argument to release mirror #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

Bug 1806782: Allow a file:// release argument to release mirror #456

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 8, 2020

This is an automated cherry-pick of #327

/assign wking

@smarterclayton
release: Allow a file:// release argument to release mirror
95de610 
When a file:// argument is provided as the source for oc adm release
mirror, do a digest lookup within that repo for any image referenced
by the payload, and if found use the local directory as the source.
This allows releases to be mirrored to disk and then oc adm release
mirror to be used to push it back with:

  oc adm release mirror file://openshift/release:4.3.1 --to REPO

where before it would fail with "invalid image reference".

Ensure that when file:// is used the correct instructions are printed
for mirroring.

Fix the mirror command provided to users to put the wildcard in
quotes (to avoid bash shell expansion).
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 8, 2020
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2020

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1806780 with correct target release. Retitling PR to link to clone:
/retitle [release-4.3] [release-4.4] Bug 1806782: Allow a file:// release argument to release mirror

Details

In response to this:

[release-4.3] [release-4.4] Bug 1806780: Allow a file:// release argument to release mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] [release-4.4] Bug 1806780: Allow a file:// release argument to release mirror [release-4.3] [release-4.4] Bug 1806782: Allow a file:// release argument to release mirror Jun 8, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign tnozicka
You can assign the PR to them by writing /assign @tnozicka in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 8, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806782, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1806780 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1806780 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents
Details

In response to this:

[release-4.3] [release-4.4] Bug 1806782: Allow a file:// release argument to release mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 8, 2020
@wking
Copy link
Member

wking commented Jun 8, 2020

/retitle Bug 1806782: Allow a file:// release argument to release mirror

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] [release-4.4] Bug 1806782: Allow a file:// release argument to release mirror Bug 1806782: Allow a file:// release argument to release mirror Jun 8, 2020
This was referenced Jun 8, 2020
Merged
Closed
Merged
@wking
Copy link
Member

wking commented Jun 8, 2020

Carried into #458 to pick up #446.

/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2020

@wking: Closed this PR.

Details

In response to this:

Carried into #458 to pick up #446.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@wking wking

Labels

bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @wking @smarterclayton