Bug 2026104: Improve errors from image append

[dmage]

This PR bumps github.com/openshift/library-go and its dependencies to update the registry client. The new client eagerly checks availability of the blob that helps with error reporting.

Tested with a fake registry: https://gist.github.com/dmage/72bb7b270b76a5faa5ff2a4698a2f27d
using the command

./oc image append --insecure --from localhost:8080/foo:latest --to docker.io/dmage/example:foo --image '{"Entrypoint":null}'

Error from a previous version:

error: uploading the source layer sha256:59bf1c3509f33515622619af21ed55bbe26d24913cedbca106468a5fb37a50c3 failed: Patch "https://registry-1.docker.io/v2/dmage/example/blobs/uploads/1887b852-544d-4a40-a6ba-2979e2b73162?_state=LB2AfV0IeTBqd...MDVaIn0%3D": received unexpected HTTP status: 503 Service Unavailable

Error from the new version:

error: uploading the source layer sha256:59bf1c3509f33515622619af21ed55bbe26d24913cedbca106468a5fb37a50c3 failed: unable to access the source layer sha256:59bf1c3509f33515622619af21ed55bbe26d24913cedbca106468a5fb37a50c3: received unexpected HTTP status: 503 Service Unavailable

[openshift-ci]

@dmage: This pull request references Bugzilla bug 2026104, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2026104: Improve errors from image append

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dmage]

/bugzilla refresh

[openshift-ci]

@dmage: This pull request references Bugzilla bug 2026104, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dmage]

/assign @soltysh

[xiuwang]

Can't build oc binary, with error ， same error in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oc/996/pull-ci-openshift-oc-master-build-rpms-from-tar/1470882972822409216

vendor/sigs.k8s.io/kustomize/kyaml/fn/runtime/runtimeutil/runtimeutil.go:18:2: cannot find package "." in:
/go/src/github.com/openshift/oc/vendor/sigs.k8s.io/kustomize/kyaml/order
vendor/sigs.k8s.io/kustomize/kyaml/yaml/rnode.go:17:2: cannot find package "." in:
/go/src/github.com/openshift/oc/vendor/sigs.k8s.io/kustomize/kyaml/sliceutil
make: *** [vendor/github.com/openshift/build-machinery-go/make/targets/golang/build.mk:16: build] Error 1

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmage
To complete the pull request process, please ask for approval from soltysh after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dmage: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-cmd	a820943	link	true	/test e2e-agnostic-cmd
ci/prow/images	a820943	link	true	/test images
ci/prow/verify	a820943	link	true	/test verify
ci/prow/e2e-aws	a820943	link	true	/test e2e-aws
ci/prow/e2e-metal-ipi-ovn-ipv6	a820943	link	false	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-serial	a820943	link	true	/test e2e-aws-serial
ci/prow/e2e-aws-upgrade	a820943	link	true	/test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dmage]

/hold
Let's wait until #992 lands.

[openshift-ci]

@dmage: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

@dmage you'll need to rebase your PR

[dmage]

This library-go is already bumped in master.

[openshift-ci]

@dmage: This pull request references Bugzilla bug 2026104. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 2026104: Improve errors from image append

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.