Skip to content

Conversation

@mdujava
Copy link
Member

@mdujava mdujava commented Mar 21, 2024

When used with python3.12, lots of deprication warnings are shown:

[...]site-packages/openshift_client/context.py:328: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    self.timeout_datetime = datetime.utcnow() + timedelta(seconds=seconds)

https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2024
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2024

Hi @mdujava. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bradmwilliams
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2024
@bradmwilliams
Copy link
Contributor

@mdujava You'll need to run ansible/rebuild_module.sh and include changes in this PR to pass CI

@bradmwilliams
Copy link
Contributor

/unlgtm

@bradmwilliams
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@bradmwilliams bradmwilliams removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@mdujava
Copy link
Member Author

mdujava commented Mar 21, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2024

@mdujava: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bradmwilliams
Copy link
Contributor

/unhold
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 21, 2024
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, mdujava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b7b4268 into openshift:main Mar 21, 2024
@mdujava mdujava deleted the utcnow branch March 21, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants