Skip to content

Bug 1829786: Allow scheduled retry of failed ImageStream import#112

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ricardomaraschini:scheduled-reimport-on-failure
May 26, 2020
Merged

Bug 1829786: Allow scheduled retry of failed ImageStream import#112
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ricardomaraschini:scheduled-reimport-on-failure

Conversation

@ricardomaraschini
Copy link
Copy Markdown
Contributor

@ricardomaraschini ricardomaraschini commented May 22, 2020

If an ImageStream tag refers to an image by SHA and we fail to import it
we need to allow the schedule process to take over an try again. With this
patch we now retry to import image stream tags based on SHA until it succeeds
at least once.

For further info on the reasoning behind this PR, please check https://coreos.slack.com/archives/CE2HALN2W/p1590050918461900

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels May 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1829786, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

WIP - Bug 1829786: Allow scheduled retry of failed ImageStream import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 22, 2020
If an ImageStream tag refers to an image by SHA and we fail to import it
we need to allow the schedule process to take over an try again. With this
patch we now retry to import image stream tags based on SHA until it succeeds
at least once.
@ricardomaraschini
Copy link
Copy Markdown
Contributor Author

/assign @dmage @bparees @adambkaplan

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1829786, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

WIP - Bug 1829786: Allow scheduled retry of failed ImageStream import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini ricardomaraschini changed the title WIP - Bug 1829786: Allow scheduled retry of failed ImageStream import Bug 1829786: Allow scheduled retry of failed ImageStream import May 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2020
@ricardomaraschini
Copy link
Copy Markdown
Contributor Author

/retitle Bug 1829786: Allow scheduled retry of failed ImageStream import

@dmage
Copy link
Copy Markdown
Contributor

dmage commented May 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2020
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5749624 into openshift:master May 26, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ricardomaraschini: All pull requests linked via external trackers have merged: openshift/openshift-controller-manager#112. Bugzilla bug 1829786 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1829786: Allow scheduled retry of failed ImageStream import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
Bug 1736812: fix apiVersion for operator config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants