Skip to content

Bug 1989772: Rebase to k8s 1.22.0-rc.0 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adambkaplan wants to merge 3 commits into from
Closed

Bug 1989772: Rebase to k8s 1.22.0-rc.0 #196

adambkaplan wants to merge 3 commits into from

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Aug 25, 2021

Rebase ocm to kube 1.22.0 (release candidate)

jkhelil and others added 3 commits August 20, 2021 09:46
@jkhelil
bump(*)
8e2e8dd
@jkhelil
code updates after rebase to k8s 1.22
277dedd
@adambkaplan
Set up metrics for authenticator and authorizer
85daa33 
Use the default factory methods to set up metrics for our token
authenticator and remote authorizer.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@adambkaplan: An error was encountered querying GitHub for users with public email (wewang@redhat.com) for bug 1989772 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1989772: Rebase to k8s 1.22.0-rc.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan
adambkaplan commented Aug 25, 2021
View reviewed changes
pkg/cmd/controller/apiserver_authenticator.go
Comment on lines +28 to +29
RecordRequestTotal: authenticatorfactory.RecordRequestTotal,
RecordRequestLatency: authenticatorfactory.RecordRequestLatency,
Copy link
Contributor Author

@adambkaplan adambkaplan Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p0lyn0mial I believe you added this in kubernetes/kubernetes#99364. Is this the right course of action, or should the metrics be a no-op?

Copy link
Contributor

@p0lyn0mial p0lyn0mial Aug 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes if we think the metrics are valuable :)

The delegated AuthN/Z uses the same metrics. Since OCM is not using the generic API library we need to wire them manually.

Copy link
Contributor Author

@adambkaplan adambkaplan Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue they aren't valuable, going to run with Jawed's current PR implementation.

pkg/cmd/controller/standalone_apiserver.go
Comment on lines +52 to +53
RecordRequestTotal: authorizerfactory.RecordRequestTotal,
RecordRequestLatency: authorizerfactory.RecordRequestLatency,
Copy link
Contributor Author

@adambkaplan adambkaplan Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p0lyn0mial likewise this was added in kubernetes/kubernetes#100339 - is this the right course of action? Or should we use a no-op?

Copy link
Contributor

@p0lyn0mial p0lyn0mial Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as 85daa33#r695940905

@adambkaplan adambkaplan mentioned this pull request Aug 25, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 85daa33 link /test e2e-aws-upgrade
ci/prow/e2e-gcp-builds 85daa33 link /test e2e-gcp-builds

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Aug 25, 2021

/close

We don't need the metrics.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@adambkaplan: Closed this PR.

Details

In response to this:

/close

We don't need the metrics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@adambkaplan: This pull request references Bugzilla bug 1989772. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1989772: Rebase to k8s 1.22.0-rc.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adambkaplan @p0lyn0mial @jkhelil