Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Oct 21, 2019

let's see what breaks
/cc @deads2k

in local testing, this looks good, once rbac is fixed. PRs to fix role/rolebinding:

(to test initially, I disabled ocm pods, saw that kcm/cluster-policy-controller container runs quota,security controllers)

@deads2k
Copy link
Contributor

deads2k commented Oct 23, 2019

/retest

1 similar comment
@sallyom
Copy link
Contributor Author

sallyom commented Oct 24, 2019

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Oct 24, 2019

/test e2e-aws

@sallyom
Copy link
Contributor Author

sallyom commented Oct 24, 2019

/test e2e-aws-upgrade

1 similar comment
@sallyom
Copy link
Contributor Author

sallyom commented Oct 24, 2019

/test e2e-aws-upgrade

@deads2k
Copy link
Contributor

deads2k commented Oct 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: deads2k, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit baeb805 into openshift:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants