Skip to content

Revert "[release-4.4] Bug 1806792: Use OwnerRefs to clean up SA pull secrets"#79

Closed
smarterclayton wants to merge 1 commit intorelease-4.4from
revert-67-cherry-pick-61-to-release-4.4
Closed

Revert "[release-4.4] Bug 1806792: Use OwnerRefs to clean up SA pull secrets"#79
smarterclayton wants to merge 1 commit intorelease-4.4from
revert-67-cherry-pick-61-to-release-4.4

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton commented Mar 26, 2020

Reverts #67

Is possibly the cause of https://bugzilla.redhat.com/show_bug.cgi?id=1785023

/hold

while we triage

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 26, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 26, 2020

@smarterclayton: This pull request references Bugzilla bug 1806792, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert "[release-4.4] Bug 1806792: Use OwnerRefs to clean up SA pull secrets"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Mar 30, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2020

@adambkaplan: This pull request references Bugzilla bug 1806792, which is invalid:

  • expected dependent Bugzilla bug 1765294 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan
adambkaplan approved these changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Mar 30, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@smarterclayton
Copy link
Copy Markdown
Contributor Author

smarterclayton commented Apr 6, 2020

Real fix is in 4.5 and appears to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@bparees bparees Awaiting requested review from bparees

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smarterclayton @openshift-ci-robot @adambkaplan