[release-4.3] Bug 1819850: Increase pull secrets controller QPS to 100 by openshift-cherrypick-robot · Pull Request #91 · openshift/openshift-controller-manager

openshift-cherrypick-robot · 2020-04-09T13:59:40Z

This is an automated cherry-pick of #84

/assign adambkaplan

Increase the k8s client QPS limit to 100, 200 burst for the service account pull secrets controller. This ensures that pull secrets for the registry are created as quickly as the tokens are generated.

openshift-ci-robot · 2020-04-09T13:59:43Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1785023, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1785023 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2020-04-09T14:00:16Z

/retitle Bug 1819850: Increase pull secrets controller QPS to 100

openshift-ci-robot · 2020-04-09T14:00:44Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1819850, which is invalid:

expected dependent Bugzilla bug 1819849 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan

/lgtm

openshift-ci-robot · 2020-04-09T14:01:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-10T01:00:29Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-10T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 1819850, which is invalid:

expected dependent Bugzilla bug 1819849 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-11T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-11T01:01:17Z

@openshift-bot: This pull request references Bugzilla bug 1819850, which is invalid:

expected dependent Bugzilla bug 1819849 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-12T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-12T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 1819850, which is invalid:

expected dependent Bugzilla bug 1819849 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-13T01:01:11Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-13T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1819850, which is invalid:

expected dependent Bugzilla bug 1819849 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-14T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-14T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 1819850, which is invalid:

expected dependent Bugzilla bug 1819849 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-15T01:01:02Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-15T01:01:38Z

@openshift-bot: This pull request references Bugzilla bug 1819850, which is invalid:

expected dependent Bugzilla bug 1819849 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2020-04-15T14:45:54Z

/bugzilla refresh

openshift-ci-robot · 2020-04-15T14:46:01Z

@adambkaplan: This pull request references Bugzilla bug 1819850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1819849 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1819849 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2020-04-15T14:46:37Z

/retitle [release-4.3] Bug 1819850: Increase pull secrets controller QPS to 100

eparis · 2020-04-16T03:24:39Z

/bugzilla refresh

openshift-ci-robot · 2020-04-16T03:24:43Z

@eparis: This pull request references Bugzilla bug 1819850, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1819849 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1819849 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-17T00:58:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-17T01:37:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-17T03:00:38Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/openshift-controller-manager#91. Bugzilla bug 1819850 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Reverting-ish the scheduler logging removed as part of c0b4905 (Remove debugging logs from scheduler component, not needed anymore, 2017-04-07). This should help troubleshoot scheduled ImageStreams that get stuck, like a cluster running the 4.3 07837c7 (Merge pull request openshift#91 from openshift-cherrypick-robot/cherry-pick-84-to-release-4.3, 2020-04-16) which had: $ oc describe is cli -n openshift Name: cli Namespace: openshift Created: 24 hours ago Labels: <none> Annotations: <none> Image Repository: default-route-openshift-image-registry.apps... Image Lookup: local=false Unique Images: 0 Tags: 1 latest updates automatically from registry quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:0a70026a8b193e61356054ab92ec825aac23c52ac5410c5e49c2412f92fe195b ! error: Import failed (InternalError): Internal error occurred: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:0a70026a8b193e61356054ab92ec825aac23c52ac5410c5e49c2412f92fe195b: Get https://quay.io/v2/openshift-release-dev/ocp-v4.0-art-dev/manifests/sha256:0a70026a8b193e61356054ab92ec825aac23c52ac5410c5e49c2412f92fe195b: received unexpected HTTP status: 500 Internal Server Error 24 hours ago But nothing useful in the controller logs: I0520 15:45:53.857152 1 controller_manager.go:42] Starting controllers on 0.0.0.0:8443 (07837c7) ... I0520 15:46:53.954352 1 scheduled_image_controller.go:67] Starting scheduled import controller ... W0520 15:47:13.662463 1 reflector.go:299] github.com/openshift/client-go/operator/informers/externalversions/factory.go:101: watch of *v1alpha1.ImageContentSourcePolicy ended with: an error on the server ("unable to decode an event from the watch stream: got short buffer with n=0, base=170, cap=2688") has prevented the request from succeeding ... I would expect... something... to show that the scheduled controller had the scheduled ImageStream in its queue and was attempting to retrieve it. The TODO I'm removing is from 01b8ae0 (Improve godoc and add validation tests, 2016-01-28), but I think removing logging should be a non-goal (although I'm fine pushing logging up to higher V-levels as folks become more confident in the logged logic).

bump dependencies

Bug 1785023: Increase pull secrets controller QPS to 100

e8e5598

Increase the k8s client QPS limit to 100, 200 burst for the service account pull secrets controller. This ensures that pull secrets for the registry are created as quickly as the tokens are generated.

openshift-ci-robot assigned adambkaplan Apr 9, 2020

openshift-cherrypick-robot mentioned this pull request Apr 9, 2020

Bug 1785023: Increase pull secrets controller QPS to 100 #84

Merged

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 9, 2020

openshift-ci-robot requested review from csrwng and mfojtik April 9, 2020 14:00

openshift-ci-robot changed the title ~~[release-4.3] Bug 1785023: Increase pull secrets controller QPS to 100~~ Bug 1819850: Increase pull secrets controller QPS to 100 Apr 9, 2020

adambkaplan approved these changes Apr 9, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 15, 2020

openshift-ci-robot changed the title ~~Bug 1819850: Increase pull secrets controller QPS to 100~~ [release-4.3] Bug 1819850: Increase pull secrets controller QPS to 100 Apr 15, 2020

eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 16, 2020

openshift-merge-robot merged commit 07837c7 into openshift:release-4.3 Apr 17, 2020

wking mentioned this pull request May 20, 2020

pkg/image/controller/scheduler: Restore some logging #110

Merged

stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021

Merge pull request openshift#91 from coreydaley/bump_deps_2

057e8ba

bump dependencies

Conversation

openshift-cherrypick-robot commented Apr 9, 2020

Uh oh!

openshift-ci-robot commented Apr 9, 2020

Uh oh!

adambkaplan commented Apr 9, 2020

Uh oh!

openshift-ci-robot commented Apr 9, 2020

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 10, 2020

Uh oh!

openshift-ci-robot commented Apr 10, 2020

Uh oh!

openshift-bot commented Apr 11, 2020

Uh oh!

openshift-ci-robot commented Apr 11, 2020

Uh oh!

openshift-bot commented Apr 12, 2020

Uh oh!

openshift-ci-robot commented Apr 12, 2020

Uh oh!

openshift-bot commented Apr 13, 2020

Uh oh!

openshift-ci-robot commented Apr 13, 2020

Uh oh!

openshift-bot commented Apr 14, 2020

Uh oh!

openshift-ci-robot commented Apr 14, 2020

Uh oh!

openshift-bot commented Apr 15, 2020

Uh oh!

openshift-ci-robot commented Apr 15, 2020

Uh oh!

adambkaplan commented Apr 15, 2020

Uh oh!

openshift-ci-robot commented Apr 15, 2020

Uh oh!

adambkaplan commented Apr 15, 2020

Uh oh!

eparis commented Apr 16, 2020

Uh oh!

openshift-ci-robot commented Apr 16, 2020

Uh oh!

openshift-bot commented Apr 17, 2020

Uh oh!

openshift-bot commented Apr 17, 2020

Uh oh!

openshift-ci-robot commented Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants