Skip to content

log aggregation created pvcs start with name logging-es-0 and not logging-es-1 #10191

Merged
mburke5678 merged 1 commit into
openshift:masterfrom
mburke5678:BZ-1585762
Jul 6, 2018
Merged

log aggregation created pvcs start with name logging-es-0 and not logging-es-1 #10191
mburke5678 merged 1 commit into
openshift:masterfrom
mburke5678:BZ-1585762

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented Jun 18, 2018 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2018
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jun 29, 2018

@sosiouxme PTAL

@mburke5678 mburke5678 closed this Jun 29, 2018
@mburke5678 mburke5678 deleted the BZ-1585762 branch June 29, 2018 18:47
@mburke5678 mburke5678 restored the BZ-1585762 branch June 29, 2018 18:52
@mburke5678 mburke5678 reopened this Jun 29, 2018
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jun 29, 2018

@sosiouxme
Luke, it appears you added some info to the Aggregated Logging topic that included:
"each PVC name will have a sequence number added to it, so logging-es-1, logging-es-2, etc."[1]

A BZ [2] suggests that the naming starts at logging-es-0 not logging-es-1. Can you comment on whether the BZ is correct?

[4] https://github.com/openshift/openshift-docs/pull/2538/files#diff-0bd2e2c1a5da6f157682d4e95ecea473R454
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1585762

cc. @ahardin-rh

@sosiouxme
Copy link
Copy Markdown
Member

sosiouxme commented Jun 29, 2018

@mburke5678 yeah, that was a long time ago and things changed with the ansible deployer! Which I think was with 3.7. The bug report looks correct to me. Thanks for checking.

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jun 29, 2018

@anpingli PTAL

1 similar comment
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 3, 2018

@anpingli PTAL

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 6, 2018

@openshift/team-documentation PTAL. Tiny change

kalexand-rh
kalexand-rh reviewed Jul 6, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be logging-es? Otherwise, LGTM

@kalexand-rh kalexand-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 6, 2018
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 6, 2018

@kalexand-rh Is this what you had in mind? ... which defaults to logging-es; ...?

@kalexand-rh
Copy link
Copy Markdown
Contributor

kalexand-rh commented Jul 6, 2018

@mburke5678, that's it! Thanks!

@mburke5678 mburke5678 merged commit c0bdbd0 into openshift:master Jul 6, 2018
@mburke5678 mburke5678 deleted the BZ-1585762 branch July 6, 2018 17:35
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 6, 2018

/cherrypick enterprise-3.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 6, 2018
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 6, 2018

@mburke5678: new pull request created: #10693

Details

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 6, 2018

/cherrypick enterprise-3.9

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 6, 2018

@mburke5678: new pull request created: #10695

Details

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 6, 2018
Merged
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 6, 2018

/cherrypick enterprise-3.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 6, 2018
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 6, 2018

@mburke5678: new pull request created: #10696

Details

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

Assignees

No one assigned

Labels

branch/enterprise-3.7 branch/enterprise-3.9 branch/enterprise-3.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mburke5678 @sosiouxme @kalexand-rh @openshift-cherrypick-robot @openshift-ci-robot