OSDOCS-16614: Documented VIP optional with user-managed LB feature#104065
OSDOCS-16614: Documented VIP optional with user-managed LB feature#104065JoeAldinger merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dfitzmau: This pull request references OSDOCS-16614 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/XS
dfitzmau
force-pushed
the
OSDOCS-16614
branch
2 times, most recently
from
ed2f3c4 to
d58bc86
Compare
openshift-ci
Bot
added
size/S
dfitzmau
force-pushed
the
OSDOCS-16614
branch
from
d58bc86 to
77ffbf5
Compare
openshift-ci
Bot
added
size/M
dfitzmau
force-pushed
the
OSDOCS-16614
branch
2 times, most recently
from
fc1d2ac to
f261856
Compare
cybertron
left a comment
cybertron
left a comment
There was a problem hiding this comment.
This can't be set via the CR, it needs to be done in install-config at initial deployment.
dfitzmau
force-pushed
the
OSDOCS-16614
branch
2 times, most recently
from
ff2b2e6 to
e9b97d8
Compare
cybertron
left a comment
cybertron
left a comment
There was a problem hiding this comment.
A couple of small suggestions inline, but overall lgtm.
| loadBalancer: | ||
| type: UserManaged | ||
| # ... | ||
| spec: |
There was a problem hiding this comment.
Oops, I didn't catch this before, but this is the wrong syntax for install-config. The example should look something like this:
platform:
baremetal:
# ...
loadBalancer:
type: UserManaged
dnsRecordsType: External
# ...
There's no spec in install-config because it's not an API in the Kubernetes sense.
There was a problem hiding this comment.
Thanks. I've updated the config to:
apiVersion: v1
baseDomain: example.com
metadata:
name: dev-cluster
# ...
platform:
baremetal:
# ...
loadBalancer:
type: UserManaged
dnsRecordsType: External
# ...
featureSet: TechPreviewNoUpgrade
pullSecret: '{"auths":{"<local_registry>": {"auth": "<credentials>","email": "you@example.com"}}}'
sshKey: 'ssh-ed25519 AAAA...'
# ...
Where # ... hides hidden YAML lines that are not in the main scope for this document.
dfitzmau
force-pushed
the
OSDOCS-16614
branch
from
83294e1 to
840fc63
Compare
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| .Prerequisites | ||
|
|
||
| * You created DNS records, such as `api`, `api-int`, or `\*.apps`. |
There was a problem hiding this comment.
\*.apps the backslash is for shell usage, is it normal style usage? I guess it's a style question.
There was a problem hiding this comment.
I'll remove. I sometimes need to add the escape character () to prevent build errors.
|
/lgtm |
kalexand-rh
added
the
merge-review-needed
lahinson
added
merge-review-in-progress
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| During pod creation, Kubernetes uses the `/etc/resolv.conf` file that exists on a node. If you modify the `/etc/resolv.conf` file on a host node, the changes do not propagate to the `/etc/resolv.conf` file that exists in a container. You must recreate the container for changes to take effect. |
There was a problem hiding this comment.
| During pod creation, Kubernetes uses the `/etc/resolv.conf` file that exists on a node. If you modify the `/etc/resolv.conf` file on a host node, the changes do not propagate to the `/etc/resolv.conf` file that exists in a container. You must recreate the container for changes to take effect. | |
| During pod creation, Kubernetes uses the `/etc/resolv.conf` file that exists on a node. If you modify the `/etc/resolv.conf` file on a host node, the changes do not propagate to the `/etc/resolv.conf` file that exists in a container. You must re-create the container for changes to take effect. |
| + | ||
| [IMPORTANT] | ||
| ==== | ||
| During pod creation, Kubernetes uses the `/etc/resolv.conf` file that exists on a node. If you modify the `/etc/resolv.conf` file on a host node, the changes do not propagate to the `/etc/resolv.conf` file that exists in a container. You must recreate the container for changes to take effect. |
There was a problem hiding this comment.
| During pod creation, Kubernetes uses the `/etc/resolv.conf` file that exists on a node. If you modify the `/etc/resolv.conf` file on a host node, the changes do not propagate to the `/etc/resolv.conf` file that exists in a container. You must recreate the container for changes to take effect. | |
| During pod creation, Kubernetes uses the `/etc/resolv.conf` file that exists on a node. If you modify the `/etc/resolv.conf` file on a host node, the changes do not propagate to the `/etc/resolv.conf` file that exists in a container. You must re-create the container for changes to take effect. |
|
|
||
| .Procedure | ||
|
|
||
| * During cluster installation, specify `TechPreviewNoUpgrade` for the `featureSet` parameter and specify `External` for the `dnsRecordsType` parameter in the `install-config.yaml` file: |
There was a problem hiding this comment.
| * During cluster installation, specify `TechPreviewNoUpgrade` for the `featureSet` parameter and specify `External` for the `dnsRecordsType` parameter in the `install-config.yaml` file: | |
| * During cluster installation, in the `install-config.yaml` file, specify `TechPreviewNoUpgrade` for the `featureSet` parameter and specify `External` for the `dnsRecordsType` parameter: |
Just a suggestion. It's a good practice to tell the user where they need to do something before you tell them what they need to do.
|
|
||
| .Prerequisites | ||
|
|
||
| * You created DNS records, such as `api`, `api-int`, or `\*.apps`. |
There was a problem hiding this comment.
I'm also curious about this line. Do you want the backslash to be visible?
lahinson
added
ok-to-merge
and removed
merge-review-in-progress
JoeAldinger
left a comment
JoeAldinger
left a comment
There was a problem hiding this comment.
/lgtm Laura, agree no stop ships but things to consider.
| // * installing/installing_bare_metal/upi/installing-bare-metal.adoc | ||
| // * installing/installing_bare_metal/upi/installing-restricted-networks-bare-metal.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
This needs to be changed to PROCEDURE
kalexand-rh
left a comment
kalexand-rh
left a comment
There was a problem hiding this comment.
@dfitzmau, please open a follow-up PR to address the review feedback on https://issues.redhat.com/browse/OSDOCS-18118 for us to merge after GA.
|
/cherrypick enterprise-4.21 |
|
@JoeAldinger: new pull request created: #105829 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
10 participants
Version(s):
4.21
Issue:
OSDOCS-16614
Link to docs preview:
openshift/api#2460