OSDOCS-17866#Support for adding BM nodes to vSphere #104754
Conversation
openshift-ci
bot
added
the
size/XS
lpettyjo
added
branch/enterprise-4.21
and removed
size/XS
|
🤖 Fri Jan 23 15:30:47 - Prow CI generated the docs preview: |
openshift-ci
bot
added
the
size/XS
storage/container_storage_interface/persistent-storage-csi-vsphere.adoc
Outdated
Show resolved
Hide resolved
lpettyjo
force-pushed
the
OSDOCS-17866
branch
from
a64d33b to
804b052
Compare
openshift-ci
bot
added
size/S
lpettyjo
force-pushed
the
OSDOCS-17866
branch
from
804b052 to
896c109
Compare
lpettyjo
force-pushed
the
OSDOCS-17866
branch
from
896c109 to
c00ee9b
Compare
|
LGTM |
|
LGTM we just need to add the XREF to the SPLAT doc section |
|
Why does the title of the PR says:
|
|
Is this the only place where we are documenting this? I feel like this document as such does not belong to storage (except may be detail about how to remove the CSI driver). |
Originally, after my discussion about this feature with Gregory it sounded like we were saying this wasn't supported. |
I have a note to xref to this content from SPLAT #105101. |
| [role="_abstract"] | ||
| Adding bare-metal nodes to an {product-title} cluster on vSphere is supported as a Technology Preview feature. | ||
|
|
||
| However, if you add bare-metal nodes, you must remove the vSphere CSI Driver, otherwise the cluster is marked as degraded. For information about how to remove the driver and the consequences of doing this, see Section _Consequences of disabling and enabling storage on vSphere_. |
There was a problem hiding this comment.
Why are we linking to "Consequence of disbaling/enabling storage on vsphere"?
Should we not link to - https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/storage/using-container-storage-interface-csi#persistent-storage-csi-vsphere-disable-storage-procedure_persistent-storage-csi-vsphere
There was a problem hiding this comment.
Yes. I've fixed it.
lpettyjo
changed the title
lpettyjo
force-pushed
the
OSDOCS-17866
branch
from
c00ee9b to
ab30774
Compare
storage/container_storage_interface/persistent-storage-csi-vsphere.adoc
Outdated
Show resolved
Hide resolved
lpettyjo
force-pushed
the
OSDOCS-17866
branch
from
ab30774 to
4d35765
Compare
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
Version(s): 4.21+
Issue: https://issues.redhat.com/browse/OSDOCS-17866
Link to docs preview: https://104754--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html
QE review:
Additional information:
PTAL: @gnufied @radeore @gcharot