-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[WIP] OSDOCS#17182: OCP 4.21 OLMv1 GA support for webhooks in bundles #104922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] OSDOCS#17182: OCP 4.21 OLMv1 GA support for webhooks in bundles #104922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsciiDocDITA bug. Snippets don't need abstracts.
b67f2c6 to
3723a4d
Compare
|
Hi @bandrade , could you help review it? Thanks! |
modules/olmv1-installing-an-operator-in-a-specific-namespace.adoc
Outdated
Show resolved
Hide resolved
4a13121 to
6a42b93
Compare
6a42b93 to
99e6960
Compare
|
/lgtm |
|
@bandrade PTAL. TY! |
|
/label merge-review-needed (I will merge, THX) |
lahinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelryanpeter Looks good! I noted one xref where the link text didn't match the page that it opened. I'll leave it up to you whether you want to change that.
99e6960 to
c45e6ca
Compare
|
New changes are detected. LGTM label has been removed. |
|
@michaelryanpeter: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 4.21
Issue: OSDOCS-17182
Link to docs preview:
xrefs and abstracts
QE review:
Additional information: