OSDOCS-17200: "Installing Bare Metal" fixing broken link#105177
OSDOCS-17200: "Installing Bare Metal" fixing broken link#105177jeana-redhat merged 1 commit intoopenshift:enterprise-4.12from
Conversation
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Thu Jan 22 12:37:44 - Prow CI generated the docs preview: |
2e11758 to
2502816
Compare
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label merge-review-needed |
ShaunaDiaz
left a comment
There was a problem hiding this comment.
The links work, however, I do not believe that RHEL 9 is supported on OpenShift 4.12 for compute nodes? Might want to double-check that this would be a valid link for FIPS since it is a regulatory issue. You might want to have 4.12 point to the RHEL 8 docs.
|
Thanks, Shauna! I'm investigating. |
2502816 to
0f7ed3e
Compare
0efcdfd to
8aeffda
Compare
8aeffda to
088c1b4
Compare
|
/label merge-review-needed |
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Ah @DCChadwick is this PR just for |
|
/retest |
|
@DCChadwick: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz Hi! I revisited this and realized I rushed it. Long story short, this PR is for 4.12 only. I'll build another PR off 4.15 to address 4.14 and 4.15. |
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@DCChadwick: This pull request references OSDOCS-17200 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label merge-review-needed |
What was the outcome here? the published 4.12 docs seem to reference RHEL 9 - was that incorrect and now this will correct the version compatibility as well as updating the links? |
@jeana-redhat When I updated the link, I accidentally linked to the RHEL 9 documentation, but I've since updated that updated link and it now points to the RHEL 8 documentation: link in this PR = https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/html/security_hardening/switching-rhel-to-fips-mode_security-hardening[Switching RHEL to FIPS mode] That "...linux/8/html..." makes all the difference in the world. I just overlooked it when I previously sent this to review (I had a "9" in that position). |
jeana-redhat
left a comment
There was a problem hiding this comment.
/remove-label merge-review-in-progress
/remove-label merge-review-needed
Version(s): 4.12
Issue: OSDOCS-17200
Link to docs preview: https://105177--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal
The fixed link appear in the two IMPORTANT blocks that begin "To enable FIPS..." (one is in the "Optional configuration parameters" table and the other is step 12 of the "Sample install-config.yaml file for bare metal" section).
QE review:
Additional information: