Skip to content

Moved json-file note from 3.7 to 3.9 per BZ#10719

Merged
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1596012
Jul 12, 2018
Merged

Moved json-file note from 3.7 to 3.9 per BZ#10719
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1596012

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented Jul 9, 2018

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2018
@mburke5678 mburke5678 added this to the Next Release milestone Jul 9, 2018
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 9, 2018

@vikram-redhat PTAL

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 10, 2018 •
edited
Loading

Per Anping Li
json-file is the default logging driver in v3.9 and later. For more detail. refer to https://bugzilla.redhat.com/show_bug.cgi?id=1513409

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 10, 2018

@jcantrill PTAL
I moved the release note regarding json-file being the default Docker logging driver from 3.7 (where it was entered erroneously) to 3.9.

jcantrill
jcantrill approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkatarki Is this erroneous in 3.7? we flopped back and forth between journal and json. @ewolinetz Maybe you know what the 3.7 default is?

@ewolinetz
Copy link
Copy Markdown

ewolinetz commented Jul 11, 2018

It looks like the default docker log driver (via Ansible) was empty... so I believe it would have been the default driver that that version of Docker configured OOTB

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 12, 2018 •
edited
Loading

@ewolinetz @jcantrill @anpingli It seems that we can merge this PR to move the release note on the default docker driver from 3.7 to 3.9 release notes, as the default was added to OpenShift in 3.9, not 3.7. Please let me know if there are any objections.

I pulled a 3.7 cluster from QuickLab. In this case, the docker version is 1.13.1 and docker info reports Logging Driver: journald. The 3.7 docs state: By default, aggregated logging uses the journald log driver. We can leave this or I can change 3.7 to state that the driver depends upon the default in Docker, if we want, through a follow-up PR.

@mburke5678 mburke5678 merged commit e303127 into openshift:master Jul 12, 2018
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 12, 2018

/cherrypick enterprise-3.7

@mburke5678 mburke5678 mentioned this pull request Jul 12, 2018
Merged
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 13, 2018

/cherrypick enterprise-3.9

@mburke5678 mburke5678 mentioned this pull request Jul 13, 2018
Merged
@mburke5678 mburke5678 deleted the BZ-1596012 branch August 2, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill approved these changes

Assignees

No one assigned

Labels

branch/enterprise-3.7 branch/enterprise-3.9 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

4 participants

@mburke5678 @ewolinetz @jcantrill @openshift-ci-robot