Update machine api docs #13890
Closed
Update machine api docs #13890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Contributor
|
Thanks @enxebre! QE agrees with you and opened bugs for some of your changes, so I'm opening a new PR to fix the merge conflict and incorporate the rest of your suggestions. Should the MachineHealthChecker be treated as a Tech Preview feature in 4.0? |
Contributor
|
The follow-up PR's here: #13891 I've asked QE to double-check the changes and am happy to make more changes if you have them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources:
Primary:
Others:
The order should be as above.
MachineHealthChecker is unrelated to autoscaling and it's experimental
MachineClasses won't be supported ion 4.0. They should not appear in the docs
ClusterAutoscalerOperator is not a resource, it's an implementation detail and should not be mentioned, or if so machine-api-operator should be as well.
Labels will need to be updated according to openshift/installer#1263
https://docs.openshift.com/container-platform/4.0/machine_management/manually-scaling-machineset.html
This can be achieved with oc scale command
cc @kalexand-rh