Enterprise 4.2 monitoring metrics ui#16495
Closed
rh-max wants to merge 3 commits intoopenshift:enterprise-4.2from
Closed
Enterprise 4.2 monitoring metrics ui#16495rh-max wants to merge 3 commits intoopenshift:enterprise-4.2from
rh-max wants to merge 3 commits intoopenshift:enterprise-4.2from
Conversation
openshift-ci-robot
added
the
size/L
Contributor
Author
|
@ahardin-rh Could you review this please? If it looks good, it should go to master too. |
Contributor
|
@rh-max can you close this and set against master first? |
Contributor
Author
|
@vikram-redhat As discussed with you, keeping this, to be merged to master in the end. |
Contributor
Author
|
@jboxman Hi Jason, could you please review, merge & cherry-pick to enterprise-4.2? Thanks! |
Contributor
Author
|
That is, cherry-pick to master (this is enterprise-4.2). |
jboxman
reviewed
Sep 18, 2019
| .Next steps | ||
|
|
||
| xref:../../monitoring/cluster-monitoring/prometheus-alertmanager-and-grafana.adoc#prometheus-alertmanager-and-grafana[Access the Prometheus, Alertmanager, and Grafana.] | ||
| xref:../../monitoring/cluster-monitoring/examining-cluster-metrics.adoc#examining-cluster-metrics[Examine cluster metrics.] |
Contributor
There was a problem hiding this comment.
I'd put the period after the link instead of as part of it.
Contributor
|
@rh-max, ideally we'd create this PR against Looks like I didn't read the initial comments first. |
Contributor
|
@rh-max, per our OpenShift docs contributing guidelines, we're wrapping text at 80 columns: |
Contributor
Author
|
Closing this in favor of #16752 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.