PROD-615-proxy-enablement#16562
Conversation
|
The preview will be available shortly at: |
|
@danehans Can you please take a look? |
|
@openshift/team-documentation For peer review please. |
There was a problem hiding this comment.
So I think the final object is simply:
apiVersion: config.openshift.io/v1
kind: Proxy
metadata:
name: cluster
spec:
trustedCA:
name: ""
There was a problem hiding this comment.
Example should be:
$ oc get proxy/cluster -o yaml
apiVersion: config.openshift.io/v1
kind: Proxy
metadata:
name: cluster
spec: {}
status: {}
@jboxman I have an open question with the installer team regarding why this field is being set when spec should be spec: {}. It's harmless that the field is set to an empty string, but may cause confusion and docs inaccuracies.
There was a problem hiding this comment.
That makes a lot more sense! Thanks!
|
@bergerhoffer, I took a look. It's late enough I'm hesitant to label Peer review completed though. |
|
@bergerhoffer after reviewing the rendered docs, my biggest concern is the documentation lives under the install section and all the docs in this PR are related to config'ing a proxy post install. The install config ( |
|
@danehans Thank you for the review! Yes I agree. This is where these docs were initially put, so I hadn't moved them yet, but I do think that this location is probably more appropriate for installing a cluster with a proxy (unless there are different steps per provider). Do you have any suggestions on where it might make most sense to put this. Under networking? |
c8aa9fe to
2ed8ff7
Compare
2ed8ff7 to
8e8a24d
Compare
|
This has been moved under Networking, new preview link is https://osdocs-468--ocpdocs.netlify.com/openshift-enterprise/latest/networking/enable-cluster-wide-proxy.html |
|
/cherrypick enterprise-4.2 |
|
@bergerhoffer: new pull request created: #16852 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR will replace #16392.