Skip to content

Change the instructions in favor of local storage for Prometheus and AM#16586

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
rh-max:monitoring-local-persistent-storage
Sep 18, 2019
Merged

Change the instructions in favor of local storage for Prometheus and AM#16586
ahardin-rh merged 1 commit intoopenshift:masterfrom
rh-max:monitoring-local-persistent-storage

Conversation

@rh-max
Copy link
Copy Markdown
Contributor

@rh-max rh-max commented Sep 11, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2019
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Sep 11, 2019

The preview will be available shortly at:

@rh-max
Copy link
Copy Markdown
Contributor Author

rh-max commented Sep 18, 2019

@ahardin-rh Could you please review this? (also to be merged to enterprise-4.2)

ahardin-rh
ahardin-rh reviewed Sep 18, 2019
View reviewed changes
Comment thread modules/monitoring-configuring-a-local-persistent-volume-claim.adoc Outdated
Copy link
Copy Markdown
Contributor

@ahardin-rh ahardin-rh Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/And to/To

ahardin-rh
ahardin-rh reviewed Sep 18, 2019
View reviewed changes
Comment thread monitoring/cluster-monitoring/configuring-the-monitoring-stack.adoc Outdated
Copy link
Copy Markdown
Contributor

@ahardin-rh ahardin-rh Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/dynamically-provisioned/dynamically provisioned

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 18, 2019
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Sep 18, 2019

Just a few minor comments. Otherwise, looks great!

@rh-max
Copy link
Copy Markdown
Contributor Author

rh-max commented Sep 18, 2019

@ahardin-rh Thank you! Last commit implements those two suggestions.

@ahardin-rh ahardin-rh added this to the Future Release milestone Sep 18, 2019
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Sep 18, 2019

@rh-max Can you please squash? Then, I will merge and cherry-pick 🍒

@rh-max rh-max force-pushed the monitoring-local-persistent-storage branch from 166ba7e to b852e0e Compare September 18, 2019 19:13
@rh-max
Copy link
Copy Markdown
Contributor Author

rh-max commented Sep 18, 2019

@ahardin-rh Sure, done! I keep forgetting to squash...

@ahardin-rh ahardin-rh merged commit ac1d7af into openshift:master Sep 18, 2019
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Sep 18, 2019

/cherrypick enterprise-4.2

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Sep 18, 2019

@ahardin-rh: new pull request created: #16744

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2019
Merged
juzhao
juzhao reviewed Sep 23, 2019
View reviewed changes
Comment thread modules/monitoring-configuring-a-local-persistent-volume-claim.adoc
@rh-max rh-max mentioned this pull request Oct 1, 2019
Merged
jboxman
jboxman reviewed Oct 1, 2019
View reviewed changes
Comment thread modules/monitoring-configuring-a-local-persistent-volume-claim.adoc
resources:
requests:
storage: *_40Gi_*
storage: *_amount of storage_*
Copy link
Copy Markdown
Contributor

@jboxman jboxman Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't using this styling for our YAML annotations (https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc#quick-markup-reference).

Copy link
Copy Markdown
Contributor Author

@rh-max rh-max Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, implemented this in #16978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

+2 more reviewers

@jboxman jboxman jboxman left review comments

@juzhao juzhao juzhao left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.2 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.2 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@rh-max @openshift-docs-preview-bot @ahardin-rh @openshift-cherrypick-robot @jboxman @juzhao @vikram-redhat @openshift-ci-robot