Skip to content

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Sep 26, 2019

Follow-up to #16458 per feedback.

Rename usage of "disconnected" to "restricted networks", and other minor edits.

Preview (internal): http://file.rdu.redhat.com/~adellape/092619/olm_restricted_network_edits/applications/operators/olm-restricted-networks.html

@adellape adellape added this to the Future Release milestone Sep 26, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2019
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kalexand-rh kalexand-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 26, 2019
@adellape adellape force-pushed the olm_restricted_network_edits branch 2 times, most recently from bb5a728 to 8acbccf Compare October 2, 2019 19:46
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2019
@adellape adellape force-pushed the olm_restricted_network_edits branch from 8acbccf to 47bcb5d Compare October 2, 2019 20:14
@adellape adellape merged commit 24636bc into openshift:master Oct 2, 2019
@adellape adellape deleted the olm_restricted_network_edits branch October 2, 2019 20:31
@adellape
Copy link
Contributor Author

adellape commented Oct 2, 2019

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@adellape: new pull request created: #17028

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Member

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.2 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants