Skip to content

Add GCP UPI install docs#17043

Merged
adellape merged 1 commit intoopenshift:masterfrom
adellape:gcp_upi
Oct 15, 2019
Merged

Add GCP UPI install docs#17043
adellape merged 1 commit intoopenshift:masterfrom
adellape:gcp_upi

Conversation

@adellape
Copy link
Copy Markdown
Contributor

@adellape adellape commented Oct 3, 2019 •
edited
Loading

@adellape adellape added this to the Future Release milestone Oct 3, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 3, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2019
@adellape adellape force-pushed the gcp_upi branch 2 times, most recently from 9c4e8a2 to 226d265 Compare October 4, 2019 20:16
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 4, 2019
@adellape adellape changed the title [WIP] Add GCP UPI install docs Add GCP UPI install docs Oct 7, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2019
@adellape adellape force-pushed the gcp_upi branch 5 times, most recently from e1401f0 to 61a6e49 Compare October 7, 2019 15:41
@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Oct 7, 2019

@kalexand-rh PTAL for peer review.
@jstuever @wking PTAL for tech review.
@wmengRH PTAL for QE review.

Thanks! 🙇‍♂️

@wmengRH
Copy link
Copy Markdown

wmengRH commented Oct 7, 2019

@jiajliu help for UPI on GCP doc review, Thanks

wking
wking reviewed Oct 7, 2019
View reviewed changes
Comment thread modules/installation-aws-user-infra-installation.adoc Outdated
wking
wking reviewed Oct 7, 2019
View reviewed changes
Comment thread modules/installation-creating-gcp-bootstrap.adoc Outdated
wking
wking reviewed Oct 7, 2019
View reviewed changes
Comment thread modules/installation-creating-gcp-bootstrap.adoc Outdated
wking
wking reviewed Oct 7, 2019
View reviewed changes
Comment thread modules/installation-extracting-infraid.adoc Outdated
wking
wking reviewed Oct 7, 2019
View reviewed changes
Comment thread modules/installation-extracting-infraid.adoc Outdated
Copy link
Copy Markdown
Member

@wking wking Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these additions, modules/installation-extracting-infraid.adoc and the Extracting the infrastructure name subject are no longer such a good match. Maybe broaden the scope to... Basic installation configuration or some such? Or punt the variables other than INFRA_ID off to a different location.

Copy link
Copy Markdown
Contributor Author

@adellape adellape Oct 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a generic modules/installating-user-infra-exporting-common-variables.adoc and couched them both in a new "Exporting common variables" section:

http://file.rdu.redhat.com/~adellape/100419/gcp_upi/installing/installing_gcp_user_infra/installing-gcp-user-infra.html#installation-gcp-user-infra-exporting-common-variables

cc @kalexand-rh

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2019
kalexand-rh
kalexand-rh reviewed Oct 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of suggestions and notes about places where we will need to untangle conflicting changes or further optimize reuse.

Comment thread installing/installing_gcp_user_infra/installing-gcp-user-infra.adoc Outdated
Comment thread installing/installing_gcp_user_infra/installing-gcp-user-infra.adoc Outdated
Comment thread modules/installation-creating-gcp-bootstrap.adoc Outdated
Comment thread modules/installation-creating-gcp-worker.adoc Outdated
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you documenting how to enable the machine API for GCP UPI clusters?

Comment thread modules/installation-creating-gcp-worker.adoc Outdated
Comment thread modules/installation-gcp-user-infra-adding-ingress.adoc Outdated
Comment thread modules/installation-gcp-user-infra-completing.adoc Outdated
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we should improve the reuse with https://github.com/openshift/openshift-docs/pull/17190/files#diff-b4f4624fd26f9cf529c5e626f5ba805fR7

Comment thread modules/installation-gcp-user-infra-completing.adoc Outdated
Comment thread modules/installation-initializing.adoc Outdated
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking, we don't have this option for AWS UPI. Do we want to add it there or remove it from GCP?

Comment thread modules/installation-user-infra-generate-k8s-manifest-ignition.adoc Outdated
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really optional?
We'll need to untangle the conflict with https://github.com/openshift/openshift-docs/pull/17016/files

@jstuever
Copy link
Copy Markdown

jstuever commented Oct 14, 2019

We use the wording The URI to the <object> a few times... we might want to modify to indicate that these are self-links. See: https://www.terraform.io/docs/providers/google/r/compute_firewall.html#self_link

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 14, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2019
@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Oct 15, 2019

@jiajliu @kalexand-rh @jstuever @wking Thanks, updated per feedback and latest discussion. Will continue looking into the few suggestions still outstanding as a follow-up.

@adellape adellape merged commit b4d14e5 into openshift:master Oct 15, 2019
@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Oct 15, 2019

/cherrypick enterprise-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 15, 2019
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Oct 15, 2019

@adellape: new pull request created: #17336

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape adellape mentioned this pull request Oct 15, 2019
Merged
@wking wking mentioned this pull request Jul 6, 2020
Merged
wking added a commit to wking/openshift-docs that referenced this pull request Jul 16, 2020
@wking
modules/installation-creating-gcp-worker: Drop 'region' from YAML
5a4c56c 
The script consuming the YAML landed without 'region' consumers in
bd08aca (Add GCP UPI install docs, 2019-10-03, openshift#17043), and still
has no consumers for that property.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Jul 27, 2020
@wking
modules/installation-creating-gcp-worker: Drop 'region' from YAML
f00389d 
The script consuming the YAML landed without 'region' consumers in
bd08aca (Add GCP UPI install docs, 2019-10-03, openshift#17043), and still
has no consumers for that property.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Jul 27, 2020
@wking
modules/installation-creating-gcp-worker: Drop 'region' from YAML
f483afc 
The script consuming the YAML landed without 'region' consumers in
bd08aca (Add GCP UPI install docs, 2019-10-03, openshift#17043), and still
has no consumers for that property.
kalexand-rh pushed a commit to kalexand-rh/openshift-docs that referenced this pull request Jul 27, 2020
@wking @kalexand-rh
modules/installation-creating-gcp-worker: Drop 'region' from YAML
7f36f24 
The script consuming the YAML landed without 'region' consumers in
bd08aca (Add GCP UPI install docs, 2019-10-03, openshift#17043), and still
has no consumers for that property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

+4 more reviewers

@wking wking wking left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@jstuever jstuever jstuever requested changes

@jiajliu jiajliu jiajliu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.2 peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.2 GA

Development

Successfully merging this pull request may close these issues.