Skip to content

Fix logging documentation for eventrouter#17052

Merged
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1758222
Oct 8, 2019
Merged

Fix logging documentation for eventrouter#17052
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1758222

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented Oct 4, 2019 •
edited
Loading

Item #2 in https://bugzilla.redhat.com/show_bug.cgi?id=1758222#c0

  1. The Deployment name should be "logging-eventrouter" instead of "cluster-logging-eventrouter" - the fluentd config expects the pod name to begin with "logging-eventrouter" - otherwise, the log records will not be assigned a UID matching the source UID of the event, they will be assigned a random UID

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2019
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Oct 4, 2019

The preview will be available shortly at:

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Oct 4, 2019

@richm Do all the instances of cluster-logging-eventrouter need to be changed to logging-eventrouter or just the deployment name?

@mburke5678 mburke5678 added this to the Next Release milestone Oct 4, 2019
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Oct 7, 2019

@xltian Can you please assign this PR for review? Thank you!

@xltian
Copy link
Copy Markdown

xltian commented Oct 8, 2019

@anpingli will review.

@anpingli
Copy link
Copy Markdown

anpingli commented Oct 8, 2019

LGTM

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Oct 8, 2019

@richm PTAL

@richm
Copy link
Copy Markdown

richm commented Oct 8, 2019

The convention for 4.x is to remove the "logging-" prefix from names of objects in the cluster like pods, deployments, secrets, configmaps, etc. I have submitted a PR for logging to fix this: https://github.com/openshift/origin-aggregated-logging/pull/1766/files#diff-6bd9f2ef704c789f35e1652b8d6d5449

Note that image names will still have a "logging-" or "origin-logging-" or "ose-logging-" prefix.

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Oct 8, 2019

@richm Thanks. I replaced the template in the docs with the one from your PR.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2019
richm
richm approved these changes Oct 8, 2019
View reviewed changes
Copy link
Copy Markdown

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 8, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@mburke5678 mburke5678 merged commit ab76173 into openshift:master Oct 8, 2019
@mburke5678 mburke5678 deleted the BZ-1758222 branch October 8, 2019 15:54
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Oct 8, 2019

/cherrypick enterprise-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 8, 2019
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Oct 8, 2019

@mburke5678: new pull request created: #17111

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Oct 8, 2019

/cherrypick enterprise-4.1

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 8, 2019
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Oct 8, 2019

@mburke5678: new pull request created: #17112

Details

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@richm richm richm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@richm richm

Labels

branch/enterprise-4.2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@mburke5678 @openshift-docs-preview-bot @xltian @anpingli @richm @openshift-ci-robot @openshift-cherrypick-robot