Skip to content

Conversation

@mburke5678
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2019
@mburke5678
Copy link
Contributor Author

@adambkaplan
Masaki Hatada suggested in the BZ [1] that the oc patch deployment command you suggested we add to the docs via #17959 (comment) is not good since it can work just once and suggested the command I added in this PR.
Can you verify Masaki's concerns and solution?

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1730148#c7

@mburke5678
Copy link
Contributor Author

@adambkaplan
Masaki Hatada suggested in the BZ [1] that the oc patch deployment command you suggested we add to the docs via #17959 (comment) is not good since it can work just once and suggested the command I added in this PR.
Can you verify Masaki's concerns and solution?

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1730148#c7

@mburke5678
Copy link
Contributor Author

@wzheng1 Please take a look. I updated the command to clear the cache after pruning based on ] https://bugzilla.redhat.com/show_bug.cgi?id=1730148#c7

@wzheng1
Copy link

wzheng1 commented Dec 20, 2019

I have verified, yes to https://bugzilla.redhat.com/show_bug.cgi?id=1730148#c7.

@mburke5678
Copy link
Contributor Author

@wzheng1 Thank you for your review. Sorry that the BZ got confusing with multiple PRs.

@mburke5678 mburke5678 merged commit 62b2cc9 into openshift:enterprise-4.2 Dec 20, 2019
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.1

@openshift-cherrypick-robot

@mburke5678: new pull request created: #18795

Details

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678 mburke5678 deleted the BZ-1730148-2 branch January 22, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.1 branch/enterprise-4.2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants