Skip to content

PR16963 Follow-up#18764

Merged
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:PR16963-follow-up
Jan 6, 2020
Merged

PR16963 Follow-up#18764
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:PR16963-follow-up

Conversation

@bmcelvee
Copy link
Copy Markdown
Contributor

@bmcelvee bmcelvee commented Dec 19, 2019

@bmcelvee bmcelvee added this to the Next Release milestone Dec 19, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2019
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Dec 19, 2019

The preview will be available shortly at:

@bmcelvee bmcelvee mentioned this pull request Dec 19, 2019
Merged
@bmcelvee
Copy link
Copy Markdown
Contributor Author

bmcelvee commented Dec 19, 2019

@ironcladlou PTAL - thanks!

@bmcelvee
Copy link
Copy Markdown
Contributor Author

bmcelvee commented Dec 19, 2019

@lihongan Please review when you get a chance, thanks!

Just to note, this is a follow-up to #16963.

@ironcladlou
Copy link
Copy Markdown
Contributor

ironcladlou commented Dec 19, 2019

Nice, thanks!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@bmcelvee bmcelvee added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 20, 2019
@bmcelvee
Copy link
Copy Markdown
Contributor Author

bmcelvee commented Dec 20, 2019

Thanks, Dan! Once the rest of the reviews are complete I will get this one merged.

@bmcelvee
Copy link
Copy Markdown
Contributor Author

bmcelvee commented Dec 20, 2019

@openshift/team-documentation please peer review, thanks!

@bobfuru bobfuru added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 20, 2019
bobfuru
bobfuru reviewed Dec 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things but otherwise LGTM!

Comment thread modules/nw-ingress-default-internal.adoc Outdated
Comment thread modules/nw-ingress-default-internal.adoc Outdated
Comment thread modules/nw-ingress-default-internal.adoc Outdated
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 20, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
@lihongan
Copy link
Copy Markdown

lihongan commented Jan 3, 2020

LGTM, thanks

@bmcelvee bmcelvee merged commit 50e2b45 into openshift:master Jan 6, 2020
@bmcelvee
Copy link
Copy Markdown
Contributor Author

bmcelvee commented Jan 6, 2020

/cherrypick enterprise-4.2

@bmcelvee
Copy link
Copy Markdown
Contributor Author

bmcelvee commented Jan 6, 2020

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 6, 2020

@bmcelvee: new pull request created: #18852

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 6, 2020

@bmcelvee: new pull request created: #18853

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bobfuru bobfuru bobfuru left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ironcladlou ironcladlou

Labels

branch/enterprise-4.2 branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@bmcelvee @openshift-docs-preview-bot @ironcladlou @openshift-ci-robot @lihongan @openshift-cherrypick-robot @bobfuru