Skip to content

Added details about creating brokers for Serverless GA#19667

Merged
adellape merged 1 commit into
openshift:masterfrom
abrennan89:broker
Mar 16, 2020
Merged

Added details about creating brokers for Serverless GA#19667
adellape merged 1 commit into
openshift:masterfrom
abrennan89:broker

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 commented Feb 11, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2020
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Feb 11, 2020

The preview will be available shortly at:

matzew
matzew reviewed Feb 12, 2020
View reviewed changes
Comment thread serverless/serverless-using-brokers.adoc Outdated
@abrennan89 abrennan89 force-pushed the broker branch 4 times, most recently from 85a9c30 to a284315 Compare February 12, 2020 18:42
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Feb 12, 2020

@maschmid if this looks OK to you now can I get a QE approved comment please? Thanks 🙂

maschmid
maschmid reviewed Feb 14, 2020
View reviewed changes
Comment thread modules/serverless-creating-broker.adoc Outdated
maschmid
maschmid reviewed Feb 14, 2020
View reviewed changes
Comment thread modules/serverless-creating-broker.adoc Outdated
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2020
matzew
matzew reviewed Mar 9, 2020
View reviewed changes
Comment thread modules/serverless-creating-broker.adoc Outdated
@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 9, 2020

@abrennan89 I think we should use the v1beta1 for broker, instead of alpha.

but other than that -> All good, I did end to end test the broker creation (manually) on OCP 4.3 with Knative eventing 0.13

@abrennan89 abrennan89 force-pushed the broker branch 2 times, most recently from 1eadc26 to 958646c Compare March 11, 2020 16:00
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2020
@abrennan89 abrennan89 requested review from maschmid and matzew March 11, 2020 16:02
@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 11, 2020

@abrennan89 do you want to cover https://knative.dev/development/eventing/channel-based-broker/#installing-broker-by-trigger-annotation in a different PR - or even in the trigger docs ?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2020
@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 11, 2020

there is a conlfict ... but,

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 11, 2020
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Mar 11, 2020

there is a conlfict ... but,

/lgtm

It was to do with unrelated changes someone made in the topic map. Fixed now.

@abrennan89 abrennan89 force-pushed the broker branch 5 times, most recently from 371a17b to 80a2b22 Compare March 11, 2020 20:24
@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 11, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
maschmid
maschmid reviewed Mar 13, 2020
View reviewed changes
Comment thread modules/serverless-creating-broker.adoc Outdated
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 16, 2020

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
@abrennan89 abrennan89 force-pushed the broker branch 2 times, most recently from 3647bf2 to 39641a8 Compare March 16, 2020 15:13
@abrennan89 abrennan89 requested a review from maschmid March 16, 2020 15:13
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Mar 16, 2020

@matzew no need to add these labels, it needs to be LGTM'd and approved by whoever does the docs peer review on the OpenShift team.

@maschmid
Copy link
Copy Markdown
Contributor

maschmid commented Mar 16, 2020

QE approved

adellape
adellape approved these changes Mar 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, but LGTM!

Comment thread modules/serverless-creating-broker.adoc Outdated
Comment thread modules/serverless-creating-broker-admin.adoc Outdated
Comment thread modules/serverless-creating-broker-admin.adoc Outdated
Comment thread modules/serverless-creating-broker.adoc Outdated
@adellape adellape changed the title [WIP] Added details about creating brokers for Serverless GA Added details about creating brokers for Serverless GA Mar 16, 2020
@adellape adellape added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2020
@adellape adellape merged commit 6c5c9d8 into openshift:master Mar 16, 2020
@adellape
Copy link
Copy Markdown
Contributor

adellape commented Mar 16, 2020

/cherrypick enterprise-4.3

@adellape
Copy link
Copy Markdown
Contributor

adellape commented Mar 16, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 16, 2020

@adellape: new pull request created: #20500

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 16, 2020

@adellape: new pull request created: #20501

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew Awaiting requested review from matzew

@maschmid maschmid Awaiting requested review from maschmid

1 more reviewer

@adellape adellape adellape approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matzew matzew

Labels

branch/enterprise-4.3 branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@abrennan89 @openshift-docs-preview-bot @matzew @openshift-ci-robot @maschmid @adellape @openshift-cherrypick-robot